Bug 65001 - REGRESSION(r90971): Placeholder and search cancel button are visible even in elements with visibility:hidden
Summary: REGRESSION(r90971): Placeholder and search cancel button are visible even in ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Major
Assignee: Kent Tamura
URL:
Keywords:
: 30608 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-07-21 18:08 PDT by Kent Tamura
Modified: 2011-09-29 21:57 PDT (History)
4 users (show)

See Also:


Attachments
Patch (6.04 KB, patch)
2011-07-21 18:28 PDT, Kent Tamura
dglazkov: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2011-07-21 18:08:43 PDT
http://code.google.com/p/chromium/issues/detail?id=90090

Shadow elements doesn't inherit the 'visibility' style?
Comment 1 Kent Tamura 2011-07-21 18:10:19 PDT
(In reply to comment #0)
> Shadow elements doesn't inherit the 'visibility' style?

Ah, they do.  We set 'visibility' explicitly for placeholder nodes and search cancel buttons.
Comment 2 Kent Tamura 2011-07-21 18:28:42 PDT
Created attachment 101684 [details]
Patch
Comment 3 Dimitri Glazkov (Google) 2011-07-21 18:43:42 PDT
Comment on attachment 101684 [details]
Patch

hello the long tail of obscure bugs.
Comment 4 Kent Tamura 2011-07-21 19:37:28 PDT
Comment on attachment 101684 [details]
Patch

Thanks!
Comment 5 WebKit Review Bot 2011-07-21 20:17:24 PDT
Comment on attachment 101684 [details]
Patch

Attachment 101684 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9191913

New failing tests:
fast/forms/search-styled.html
fast/forms/placeholder-pseudo-style.html
fast/forms/textarea-placeholder-pseudo-style.html
fast/forms/password-placeholder.html
fast/forms/textarea-placeholder-wrapping.html
fast/forms/placeholder-position.html
fast/css/pseudo-cache-stale.html
fast/forms/password-placeholder-text-security.html
fast/forms/isindex-placeholder.html
fast/forms/input-placeholder-text-indent.html
fast/forms/placeholder-stripped.html
Comment 6 Kent Tamura 2011-07-21 20:24:16 PDT
(In reply to comment #5)
> (From update of attachment 101684 [details])
> Attachment 101684 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/9191913
> 
> New failing tests:
> fast/forms/search-styled.html
> fast/forms/placeholder-pseudo-style.html
> fast/forms/textarea-placeholder-pseudo-style.html
> fast/forms/password-placeholder.html
> fast/forms/textarea-placeholder-wrapping.html
> fast/forms/placeholder-position.html
> fast/css/pseudo-cache-stale.html
> fast/forms/password-placeholder-text-security.html
> fast/forms/isindex-placeholder.html
> fast/forms/input-placeholder-text-indent.html
> fast/forms/placeholder-stripped.html

Oops, we should not check renderer() in placeholderShouldBeVisible().
I'll fix it.
Comment 7 Kent Tamura 2011-07-21 20:31:41 PDT
Committed r91550: <http://trac.webkit.org/changeset/91550>
Comment 8 Kent Tamura 2011-07-21 22:36:10 PDT
A follow-up change: http://trac.webkit.org/changeset/91556
Comment 9 Alexey Proskuryakov 2011-09-29 21:57:08 PDT
*** Bug 30608 has been marked as a duplicate of this bug. ***