Bug 64998 - Refactor Trac.js for use in garden-o-matic
Summary: Refactor Trac.js for use in garden-o-matic
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-21 17:04 PDT by Adam Barth
Modified: 2011-07-21 17:29 PDT (History)
1 user (show)

See Also:


Attachments
Patch (25.95 KB, patch)
2011-07-21 17:05 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (25.96 KB, patch)
2011-07-21 17:10 PDT, Adam Barth
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-07-21 17:04:26 PDT
Refactor Trac.js for use in garden-o-matic
Comment 1 Adam Barth 2011-07-21 17:05:56 PDT
Created attachment 101671 [details]
Patch
Comment 2 Adam Barth 2011-07-21 17:10:17 PDT
Created attachment 101673 [details]
Patch
Comment 3 Adam Roben (:aroben) 2011-07-21 17:21:59 PDT
Comment on attachment 101671 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101671&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:83
> +        expectedDescription: 'css1/basic/class_as_selector.html started failing on Windows 7 Release (Tests) between r9 and r10 (inclusive).\n\nhttp://trac.webkit.org/log/trunkrev=10&stop_rev=9\n\n[RESULTS PAGE URL Windows 7 Release (Tests), r8 (2)] passed\n[RESULTS PAGE URL Windows 7 Release (Tests), r10 (5)] failed\n',

This looks like a ? is missing.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:93
> +        expectedDescription: 'css1/basic/class_as_selector.html and fast/css/ex-after-font-variant.html started failing on Windows 7 Release (Tests) between r9 and r10 (inclusive).\n\nhttp://trac.webkit.org/log/trunkrev=10&stop_rev=9\n\n[RESULTS PAGE URL Windows 7 Release (Tests), r8 (2)] passed\n[RESULTS PAGE URL Windows 7 Release (Tests), r10 (5)] failed\n',

Same here.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:109
> +        expectedDescription: 'The following tests started failing on Windows 7 Release (Tests) between r9 and r10 (inclusive):\n\n    css1/basic/class_as_selector1.html\n    css1/basic/class_as_selector2.html\n    css1/basic/class_as_selector3.html\n    css1/basic/class_as_selector4.html\n    css1/basic/class_as_selector5.html\n    css1/basic/class_as_selector6.html\n    css1/basic/class_as_selector7.html\n    css1/basic/class_as_selector8.html\n\nhttp://trac.webkit.org/log/trunkrev=10&stop_rev=9\n\n[RESULTS PAGE URL Windows 7 Release (Tests), r8 (2)] passed\n[RESULTS PAGE URL Windows 7 Release (Tests), r10 (5)] failed\n',

And here.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:167
> +        this._callbackCache[key].push(callback);

s/this/self/

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:181
> +        $.each(callbackList, function(index, cachedCallback) {
> +            cachedCallback(data);
> +        });

callbackList.forEach could work too.
Comment 4 Adam Barth 2011-07-21 17:29:48 PDT
Committed r91538: <http://trac.webkit.org/changeset/91538>