Bug 64996 – Gif animations stop working if system time is changed to a time in past

• Status: RESOLVED
• Resolution: FIXED
• Component: Images

[Devdatta Deshpande]

Steps to reproduce:

1. Launch a web-page with animated gif images. For e.g. http://en.wikipedia.org/wiki/Graphics_Interchange_Format
2. While the animation is on, change the system time to a time in past.

Result:
Observe that the gif animations stop working.

Expected behavior:
Animation should work independent of change in system time.

[Devdatta Deshpande]

Created attachment 101669 [details]
Patch

[Martin Robinson]

Comment on attachment 101669 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101669&action=review

> Source/WebCore/ChangeLog:10
> +        Test: Load http://en.wikipedia.org/wiki/Graphics_Interchange_Format
> +        Change system time to a time in past
> +

Is there a test in manual-tests that uses an animated GIF? If so it might be better to refer to that one.

[Devdatta Deshpande]

Created attachment 102302 [details]
Patch

[James Robinson]

Comment on attachment 102302 [details]
Patch

Patch looks great!  Thanks for fixing this.

Do you need help committing this?  Mark the "cq" flag "cq?" to request a commit from the commit bot, if so.

[WebKit Review Bot]

Comment on attachment 102302 [details]
Patch

Clearing flags on attachment: 102302

Committed r91960: <http://trac.webkit.org/changeset/91960>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.