Bug 64996 - Gif animations stop working if system time is changed to a time in past
Summary: Gif animations stop working if system time is changed to a time in past
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL: http://en.wikipedia.org/wiki/Graphics...
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-21 16:58 PDT by Devdatta Deshpande
Modified: 2011-07-28 17:02 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.35 KB, patch)
2011-07-21 17:03 PDT, Devdatta Deshpande 		no flags Details | Formatted Diff | Diff
Patch (1.38 KB, patch)
2011-07-28 14:51 PDT, Devdatta Deshpande 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devdatta Deshpande 2011-07-21 16:58:01 PDT 
Steps to reproduce:

1. Launch a web-page with animated gif images. For e.g. http://en.wikipedia.org/wiki/Graphics_Interchange_Format
2. While the animation is on, change the system time to a time in past.

Result:
Observe that the gif animations stop working.

Expected behavior:
Animation should work independent of change in system time.
Comment 1 Devdatta Deshpande 2011-07-21 17:03:16 PDT 
Created attachment 101669 [details]
Patch
Comment 2 Martin Robinson 2011-07-28 10:18:23 PDT 
Comment on attachment 101669 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101669&action=review

> Source/WebCore/ChangeLog:10
> +        Test: Load http://en.wikipedia.org/wiki/Graphics_Interchange_Format
> +        Change system time to a time in past
> +

Is there a test in manual-tests that uses an animated GIF? If so it might be better to refer to that one.
Comment 3 Devdatta Deshpande 2011-07-28 14:51:40 PDT 
Created attachment 102302 [details]
Patch
Comment 4 James Robinson 2011-07-28 14:55:53 PDT 
Comment on attachment 102302 [details]
Patch

Patch looks great!  Thanks for fixing this.

Do you need help committing this?  Mark the "cq" flag "cq?" to request a commit from the commit bot, if so.
Comment 5 WebKit Review Bot 2011-07-28 17:02:43 PDT 
Comment on attachment 102302 [details]
Patch

Clearing flags on attachment: 102302

Committed r91960: <http://trac.webkit.org/changeset/91960>
Comment 6 WebKit Review Bot 2011-07-28 17:02:47 PDT 
All reviewed patches have been landed.  Closing bug.