Bug 64993 - Concentrate RenderLayer repaint rects updates
Summary: Concentrate RenderLayer repaint rects updates
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-21 16:32 PDT by Julien Chaffraix
Modified: 2011-08-25 16:40 PDT (History)
4 users (show)

See Also:


Attachments
Proposed refactoring. (6.83 KB, patch)
2011-07-21 16:43 PDT, Julien Chaffraix
no flags Details | Formatted Diff | Diff
Patch for landing (7.10 KB, patch)
2011-08-25 13:47 PDT, Julien Chaffraix
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2011-07-21 16:32:21 PDT
This refactoring makes it easier to see where the 2 repaint rectangles are updated. It also needs us to add more ASSERT and underline a potential optimization.
Comment 1 Julien Chaffraix 2011-07-21 16:43:09 PDT
Created attachment 101664 [details]
Proposed refactoring.
Comment 2 Dave Hyatt 2011-08-25 13:06:44 PDT
Comment on attachment 101664 [details]
Proposed refactoring.

r=me
Comment 3 WebKit Review Bot 2011-08-25 13:22:55 PDT
Comment on attachment 101664 [details]
Proposed refactoring.

Rejecting attachment 101664 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2

Last 500 characters of output:
RenderLayer.cpp
Hunk #1 FAILED at 309.
Hunk #2 FAILED at 370.
Hunk #3 succeeded at 514 (offset 9 lines).
2 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/rendering/RenderLayer.cpp.rej
patching file Source/WebCore/rendering/RenderLayer.h
Hunk #1 FAILED at 403.
1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/rendering/RenderLayer.h.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'David Hyatt', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/9507516
Comment 4 Julien Chaffraix 2011-08-25 13:47:31 PDT
Created attachment 105238 [details]
Patch for landing
Comment 5 WebKit Review Bot 2011-08-25 16:40:12 PDT
Comment on attachment 105238 [details]
Patch for landing

Clearing flags on attachment: 105238

Committed r93837: <http://trac.webkit.org/changeset/93837>
Comment 6 WebKit Review Bot 2011-08-25 16:40:18 PDT
All reviewed patches have been landed.  Closing bug.