Bug 6498 - SelectionController's setters should notify delegates of selection changes
Summary: SelectionController's setters should notify delegates of selection changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Justin Garcia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-11 19:55 PST by Justin Garcia
Modified: 2006-09-05 15:29 PDT (History)
2 users (show)

See Also:

Attachments
patch w/o layout test changes (99.37 KB, patch)
2006-08-31 17:48 PDT, Justin Garcia 		no flags Details | Formatted Diff | Diff
patch w/o layout test changes (99.85 KB, patch)
2006-08-31 17:58 PDT, Justin Garcia 		no flags Details | Formatted Diff | Diff
patch w/o layout test changes (99.55 KB, patch)
2006-08-31 20:46 PDT, Justin Garcia 		justin.garcia: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Garcia 2006-01-11 19:55:26 PST 
To get selection notifications sent to delegates, you have to call m_frame->setSelection().  This 
idiosyncrasy caused a layout test failure after maciej removed clearSelection() { m_frame->setSelection
(SelectionController()) } and replaced calls to it with selection().clear().  Since it's non-obvious, and since I 
want to make the JS Selection Object a wrapper around a SelectionController and not an m_frame, I want 
to fix this.
Comment 1 Justin Garcia 2006-08-31 17:48:59 PDT 
Created attachment 10340 [details]
patch w/o layout test changes

Not included in the patch is a layout test and changes to layout test results (nearly all editing layout tests have extra didChangeSelection calls from Selection changes that weren't reported before).
Comment 2 Justin Garcia 2006-08-31 17:58:03 PDT 
Created attachment 10341 [details]
patch w/o layout test changes
Comment 3 Justin Garcia 2006-08-31 20:46:42 PDT 
Created attachment 10344 [details]
patch w/o layout test changes
Comment 4 Justin Garcia 2006-09-01 17:38:20 PDT 
Comment on attachment 10344 [details]
patch w/o layout test changes

tim reviewed this
Comment 5 Justin Garcia 2006-09-05 15:29:09 PDT 
r16237