Bug 64975 - Column spans and multi-column elements should not collapse margins with their children
Summary: Column spans and multi-column elements should not collapse margins with their...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-21 14:00 PDT by Dave Hyatt
Modified: 2011-07-22 18:19 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.72 KB, patch)
2011-07-21 14:02 PDT, Dave Hyatt
bdakin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2011-07-21 14:00:21 PDT
Column spans and multi-column elements should establish block formatting contexts. They mostly do except for the part where they should not be collapsing margins with their children. This bug is about fixing the margin collapsing issue.
Comment 1 Dave Hyatt 2011-07-21 14:02:30 PDT
Created attachment 101642 [details]
Patch
Comment 2 Dave Hyatt 2011-07-21 14:17:11 PDT
Fixed in r91497. A bunch of multicol tests will need to be rebaselined. I'm on Lion so can't do SL.
Comment 3 Philippe Wittenbergh 2011-07-22 18:19:22 PDT
Should '-webkit-column-count:0' establish a block formatting context and prevent margin-collapse through ?

It does with the latest nightly (r91611) on Snow leopard.
The spec says: "Values must be greater than 0"
http://dev.w3.org/csswg/css3-multicol/#cc

Opera 11.5 does not establish a BFC - the margins of the child element collapse through (unless of course the multi-col element has a border)

testcase:
http://dev.l-c-n.com/CSS3/multi-col/multicol-bfc3.html