WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
Bug 64929
Web Inspector: support object notation in generated agents on front-end.
https://bugs.webkit.org/show_bug.cgi?id=64929
Summary
Web Inspector: support object notation in generated agents on front-end.
Pavel Feldman
Reported
2011-07-21 02:47:54 PDT
Today: var urlRegex = "debugger-set-breakpoint.*"; var lineNumber = 8; var columnNumber = undefined; var condition = undefined; var isRegex = true; DebuggerAgent.setBreakpointByUrl(url, lineNumber, columnNumber, condition, isRegex); Desired: DebuggerAgent.setBreakpointByUrl({ url: "debugger-set-breakpoint.*", lineNumber: 8, isRegex: true });
Attachments
Add attachment
proposed patch, testcase, etc.
Patrick Mueller
Comment 1
2011-07-21 05:29:19 PDT
Are you planning on changing the APIs, or accepting object/properties as an alternative to the existing APIs? Your example doesn't include a callback function. Will those be a property of the object parameter as well? I rather like the convention of having the callback function specified at the end of the parameter list.
Pavel Feldman
Comment 2
2011-07-21 05:30:11 PDT
(In reply to
comment #1
)
> Are you planning on changing the APIs, or accepting object/properties as an alternative to the existing APIs? > > Your example doesn't include a callback function. Will those be a property of the object parameter as well? I rather like the convention of having the callback function specified at the end of the parameter list.
It should definitely stay: DebuggerAgent.setBreakpointByUrl({ url: "debugger-set-breakpoint.*", lineNumber: 8, isRegex: true }, callback);
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug