Bug 64917 - load() does not reset the resource selection algorithm
Summary: load() does not reset the resource selection algorithm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-07-20 19:24 PDT by Eric Carlson
Modified: 2011-09-06 11:49 PDT (History)
2 users (show)

See Also:


Attachments
Proposed patch. (9.73 KB, patch)
2011-07-20 20:06 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff
Proposed patch. (9.16 KB, patch)
2011-07-20 20:09 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff
Updated patch (9.21 KB, patch)
2011-09-01 14:11 PDT, Eric Carlson
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2011-07-20 19:24:40 PDT
Calling the load() method on a media element should reset state so the resource selection algorithm starts over, but <source> element selection is not reset.
Comment 1 Eric Carlson 2011-07-20 19:25:01 PDT
<rdar://9712909>
Comment 2 Eric Carlson 2011-07-20 20:06:33 PDT
Created attachment 101549 [details]
Proposed patch.
Comment 3 WebKit Review Bot 2011-07-20 20:08:43 PDT
Attachment 101549 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/medi..." exit_code: 1

Source/WebCore/platform/graphics/MediaPlayer.cpp:197:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Eric Carlson 2011-07-20 20:09:50 PDT
Created attachment 101550 [details]
Proposed patch.
Comment 5 Eric Carlson 2011-09-01 14:11:37 PDT
Created attachment 106027 [details]
Updated patch

Update results slightly
Comment 6 Eric Carlson 2011-09-06 11:49:26 PDT
http://trac.webkit.org/changeset/94584