Bug 64907 - [Qt] Qt5 Build Fix: remove useless use of qRound(int)
Summary: [Qt] Qt5 Build Fix: remove useless use of qRound(int)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Blocker
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-20 17:15 PDT by Rohan McGovern
Modified: 2011-07-21 02:29 PDT (History)
1 user (show)

See Also:


Attachments
[PATCH] Qt5 Build Fix: remove useless use of qRound(int) (2.76 KB, patch)
2011-07-20 17:41 PDT, Rohan McGovern
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rohan McGovern 2011-07-20 17:15:54 PDT
Rounding an integer doesn't make sense.

Since 2dcd3939a8bd5ff743e4c87f87b2d81b1a101467 in qtbase, code using qRound(int) does not compile:

  Source/WebCore/platform/graphics/qt/FontPlatformDataQt.cpp: In constructor 'WebCore::FontPlatformData::FontPlatformData(const WebCore::FontDescription&, const WTF::AtomicString&, int, int)':
  Source/WebCore/platform/graphics/qt/FontPlatformDataQt.cpp:67: error: call of overloaded 'qRound(int)' is ambiguous
  ../qtbase/include/QtCore/../../src/corelib/global/qglobal.h:1176: note: candidates are: int qRound(double)
  ../qtbase/include/QtCore/../../src/corelib/global/qglobal.h:1178: note:                 int qRound(float)
  Source/WebCore/platform/graphics/qt/FontPlatformDataQt.cpp:69: error: call of overloaded 'qRound(int&)' is ambiguous
  ../qtbase/include/QtCore/../../src/corelib/global/qglobal.h:1176: note: candidates are: int qRound(double)
  ../qtbase/include/QtCore/../../src/corelib/global/qglobal.h:1178: note:                 int qRound(float)
Comment 1 Rohan McGovern 2011-07-20 17:41:26 PDT
Created attachment 101537 [details]
[PATCH] Qt5 Build Fix: remove useless use of qRound(int)
Comment 2 Noam Rosenthal 2011-07-21 01:27:19 PDT
Comment on attachment 101537 [details]
[PATCH] Qt5 Build Fix: remove useless use of qRound(int)

LGTM
Comment 3 WebKit Review Bot 2011-07-21 02:29:35 PDT
Comment on attachment 101537 [details]
[PATCH] Qt5 Build Fix: remove useless use of qRound(int)

Clearing flags on attachment: 101537

Committed r91452: <http://trac.webkit.org/changeset/91452>
Comment 4 WebKit Review Bot 2011-07-21 02:29:39 PDT
All reviewed patches have been landed.  Closing bug.