Rounding an integer doesn't make sense. Since 2dcd3939a8bd5ff743e4c87f87b2d81b1a101467 in qtbase, code using qRound(int) does not compile: Source/WebCore/platform/graphics/qt/FontPlatformDataQt.cpp: In constructor 'WebCore::FontPlatformData::FontPlatformData(const WebCore::FontDescription&, const WTF::AtomicString&, int, int)': Source/WebCore/platform/graphics/qt/FontPlatformDataQt.cpp:67: error: call of overloaded 'qRound(int)' is ambiguous ../qtbase/include/QtCore/../../src/corelib/global/qglobal.h:1176: note: candidates are: int qRound(double) ../qtbase/include/QtCore/../../src/corelib/global/qglobal.h:1178: note: int qRound(float) Source/WebCore/platform/graphics/qt/FontPlatformDataQt.cpp:69: error: call of overloaded 'qRound(int&)' is ambiguous ../qtbase/include/QtCore/../../src/corelib/global/qglobal.h:1176: note: candidates are: int qRound(double) ../qtbase/include/QtCore/../../src/corelib/global/qglobal.h:1178: note: int qRound(float)
Created attachment 101537 [details] [PATCH] Qt5 Build Fix: remove useless use of qRound(int)
Comment on attachment 101537 [details] [PATCH] Qt5 Build Fix: remove useless use of qRound(int) LGTM
Comment on attachment 101537 [details] [PATCH] Qt5 Build Fix: remove useless use of qRound(int) Clearing flags on attachment: 101537 Committed r91452: <http://trac.webkit.org/changeset/91452>
All reviewed patches have been landed. Closing bug.