RESOLVED FIXED 64906
CSS top margin collapses when paginating 
https://bugs.webkit.org/show_bug.cgi?id=64906
Summary CSS top margin collapses when paginating
Sam Weinig
Reported 2011-07-20 17:04:42 PDT
CSS top margin collapses when printing
Attachments
Patch (131.67 KB, patch)
2011-07-20 17:14 PDT, Sam Weinig 		hyatt: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2011-07-20 17:05:33 PDT
<rdar://problem/9434990>
Sam Weinig
Comment 2 2011-07-20 17:14:09 PDT
Created attachment 101530 [details] Patch
WebKit Review Bot
Comment 3 2011-07-20 17:15:49 PDT
Attachment 101530 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Source/WebCore/rendering/RenderBlock.cpp:5992: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dave Hyatt
Comment 4 2011-07-20 17:19:09 PDT
Comment on attachment 101530 [details] Patch r=me Might be nice to put view()->layoutState() in a local now though since it is accessed twice.
WebKit Review Bot
Comment 5 2011-07-20 19:04:18 PDT
Comment on attachment 101530 [details] Patch Attachment 101530 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9193498 New failing tests: fast/multicol/span/anonymous-before-child-parent-crash.html fast/multicol/client-rects.html fast/multicol/scrolling-overflow.html fast/multicol/span/span-as-immediate-child-generated-content.html fast/multicol/float-avoidance.html fast/multicol/vertical-lr/float-avoidance.html fast/multicol/span/span-as-immediate-columns-child-removal.html fast/multicol/span/span-as-immediate-columns-child-dynamic.html fast/multicol/vertical-rl/float-avoidance.html fast/multicol/span/span-as-immediate-columns-child.html fast/multicol/span/span-as-nested-columns-child-dynamic.html fast/multicol/span/span-as-immediate-child-property-removal.html fast/multicol/span/span-as-nested-columns-child.html fast/events/offsetX-offsetY.html fast/multicol/vertical-rl/float-multicol.html fast/multicol/vertical-lr/float-multicol.html
Sam Weinig
Comment 6 2011-07-21 09:14:23 PDT
Committed r91474: <http://trac.webkit.org/changeset/91474>
Note You need to log in before you can comment on or make changes to this bug.