CSS top margin collapses when printing
<rdar://problem/9434990>
Created attachment 101530 [details] Patch
Attachment 101530 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Source/WebCore/rendering/RenderBlock.cpp:5992: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 101530 [details] Patch r=me Might be nice to put view()->layoutState() in a local now though since it is accessed twice.
Comment on attachment 101530 [details] Patch Attachment 101530 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9193498 New failing tests: fast/multicol/span/anonymous-before-child-parent-crash.html fast/multicol/client-rects.html fast/multicol/scrolling-overflow.html fast/multicol/span/span-as-immediate-child-generated-content.html fast/multicol/float-avoidance.html fast/multicol/vertical-lr/float-avoidance.html fast/multicol/span/span-as-immediate-columns-child-removal.html fast/multicol/span/span-as-immediate-columns-child-dynamic.html fast/multicol/vertical-rl/float-avoidance.html fast/multicol/span/span-as-immediate-columns-child.html fast/multicol/span/span-as-nested-columns-child-dynamic.html fast/multicol/span/span-as-immediate-child-property-removal.html fast/multicol/span/span-as-nested-columns-child.html fast/events/offsetX-offsetY.html fast/multicol/vertical-rl/float-multicol.html fast/multicol/vertical-lr/float-multicol.html
Committed r91474: <http://trac.webkit.org/changeset/91474>
It appears that fast/events/offsetX-offsetY.html started failing after this patch: http://build.webkit.org/waterfall?show=SnowLeopard%20Intel%20Release%20(Tests) http://build.webkit.org/builders/Chromium%20Linux%20Release%20%28Tests%29/builds/21340 http://build.webkit.org/builders/Windows%207%20Release%20%28Tests%29/builds/14946