Bug 64906 - CSS top margin collapses when paginating
Summary: CSS top margin collapses when paginating
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2011-07-20 17:04 PDT by Sam Weinig
Modified: 2011-07-21 11:21 PDT (History)
4 users (show)

See Also:


Attachments
Patch (131.67 KB, patch)
2011-07-20 17:14 PDT, Sam Weinig
hyatt: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-07-20 17:04:42 PDT
CSS top margin collapses when printing
Comment 1 Sam Weinig 2011-07-20 17:05:33 PDT
<rdar://problem/9434990>
Comment 2 Sam Weinig 2011-07-20 17:14:09 PDT
Created attachment 101530 [details]
Patch
Comment 3 WebKit Review Bot 2011-07-20 17:15:49 PDT
Attachment 101530 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

Source/WebCore/rendering/RenderBlock.cpp:5992:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Dave Hyatt 2011-07-20 17:19:09 PDT
Comment on attachment 101530 [details]
Patch

r=me

Might be nice to put view()->layoutState() in a local now though since it is accessed twice.
Comment 5 WebKit Review Bot 2011-07-20 19:04:18 PDT
Comment on attachment 101530 [details]
Patch

Attachment 101530 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9193498

New failing tests:
fast/multicol/span/anonymous-before-child-parent-crash.html
fast/multicol/client-rects.html
fast/multicol/scrolling-overflow.html
fast/multicol/span/span-as-immediate-child-generated-content.html
fast/multicol/float-avoidance.html
fast/multicol/vertical-lr/float-avoidance.html
fast/multicol/span/span-as-immediate-columns-child-removal.html
fast/multicol/span/span-as-immediate-columns-child-dynamic.html
fast/multicol/vertical-rl/float-avoidance.html
fast/multicol/span/span-as-immediate-columns-child.html
fast/multicol/span/span-as-nested-columns-child-dynamic.html
fast/multicol/span/span-as-immediate-child-property-removal.html
fast/multicol/span/span-as-nested-columns-child.html
fast/events/offsetX-offsetY.html
fast/multicol/vertical-rl/float-multicol.html
fast/multicol/vertical-lr/float-multicol.html
Comment 6 Sam Weinig 2011-07-21 09:14:23 PDT
Committed r91474: <http://trac.webkit.org/changeset/91474>