RESOLVED FIXED 64899
show a list of average test times in the treemap 
https://bugs.webkit.org/show_bug.cgi?id=64899
Summary show a list of average test times in the treemap
Ojan Vafai
Reported 2011-07-20 16:04:01 PDT
show a list of average test times in the treemap
Attachments
Patch (5.60 KB, patch)
2011-07-20 16:05 PDT, Ojan Vafai 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2011-07-20 16:05:25 PDT
Created attachment 101523 [details] Patch
Adam Roben (:aroben)
Comment 2 2011-07-20 16:09:31 PDT
Comment on attachment 101523 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101523&action=review > Tools/TestResultServer/static-dashboards/treemap.html:206 > + if (avgA > avgB) > + return -1; > + else if (avgA == avgB) > + return 0; > + else > + return 1; It's simpler to say: return avgB - avgA;
Ojan Vafai
Comment 3 2011-07-20 16:13:57 PDT
(In reply to comment #2) > (From update of attachment 101523 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=101523&action=review > > > Tools/TestResultServer/static-dashboards/treemap.html:206 > > + if (avgA > avgB) > > + return -1; > > + else if (avgA == avgB) > > + return 0; > > + else > > + return 1; > > It's simpler to say: > > return avgB - avgA; Whoops. I had it in my head that this was an issue in some cases, but that's only when strings are involved.
Ojan Vafai
Comment 4 2011-07-20 16:15:35 PDT
Committed r91415: <http://trac.webkit.org/changeset/91415>
Note You need to log in before you can comment on or make changes to this bug.