Bug 64899 - show a list of average test times in the treemap
Summary: show a list of average test times in the treemap
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-20 16:04 PDT by Ojan Vafai
Modified: 2011-07-20 16:15 PDT (History)
1 user (show)

See Also:

Attachments
Patch (5.60 KB, patch)
2011-07-20 16:05 PDT, Ojan Vafai 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2011-07-20 16:04:01 PDT 
show a list of average test times in the treemap
Comment 1 Ojan Vafai 2011-07-20 16:05:25 PDT 
Created attachment 101523 [details]
Patch
Comment 2 Adam Roben (:aroben) 2011-07-20 16:09:31 PDT 
Comment on attachment 101523 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101523&action=review

> Tools/TestResultServer/static-dashboards/treemap.html:206
> +        if (avgA > avgB)
> +            return -1;
> +        else if (avgA == avgB)
> +            return 0;
> +        else
> +            return 1;

It's simpler to say:

return avgB - avgA;
Comment 3 Ojan Vafai 2011-07-20 16:13:57 PDT 
(In reply to comment #2)
> (From update of attachment 101523 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=101523&action=review
> 
> > Tools/TestResultServer/static-dashboards/treemap.html:206
> > +        if (avgA > avgB)
> > +            return -1;
> > +        else if (avgA == avgB)
> > +            return 0;
> > +        else
> > +            return 1;
> 
> It's simpler to say:
> 
> return avgB - avgA;

Whoops. I had it in my head that this was an issue in some cases, but that's only when strings are involved.
Comment 4 Ojan Vafai 2011-07-20 16:15:35 PDT 
Committed r91415: <http://trac.webkit.org/changeset/91415>