Bug 64877 - [Qt] Adopt existing GraphicsContext3D members (part 1)
: [Qt] Adopt existing GraphicsContext3D members (part 1)
Status: RESOLVED FIXED
: WebKit
WebKit Qt
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
: 57261 64878
  Show dependency treegraph
 
Reported: 2011-07-20 10:10 PST by
Modified: 2011-07-21 08:12 PST (History)


Attachments
adopt GraphicsContext3D members (21.97 KB, patch)
2011-07-20 10:42 PST, Andrew Wason
noam: review-
Review Patch | Details | Formatted Diff | Diff
update ChangeLog (22.19 KB, patch)
2011-07-21 07:03 PST, Andrew Wason
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-07-20 10:10:59 PST
This is part 1 of a 3 part migration for bug 57261 to migrate to GraphicsContext3DOpenGL.cpp for Qt.

Part 1 adopts existing GraphicsContext3D members for Qt. Move member vars and their initialization,
and the GraphicsContext3DInternal::reshape() method out of GraphicsContext3DInternal and into
GraphicsContext3D where they will be used when we adopt GraphicsContext3DOpenGL.cpp
------- Comment #1 From 2011-07-20 10:42:22 PST -------
Created an attachment (id=101483) [details]
adopt GraphicsContext3D members
------- Comment #2 From 2011-07-21 01:48:33 PST -------
(From update of attachment 101483 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=101483&action=review

The code changes are good. Please resubmit with a more informative ChangeLog.

> Source/WebCore/ChangeLog:8
> +        Existing webgl layout tests should test this.

WebGL, not webgl.

> Source/WebCore/ChangeLog:11
> +        where they will be needed when we adopt GraphicsContext3DOpenGL.cpp

Missing a period, this upsets some people :)
------- Comment #3 From 2011-07-21 07:03:20 PST -------
Created an attachment (id=101583) [details]
update ChangeLog
------- Comment #4 From 2011-07-21 07:13:41 PST -------
(From update of attachment 101583 [details])
LGTM
------- Comment #5 From 2011-07-21 08:12:19 PST -------
(From update of attachment 101583 [details])
Clearing flags on attachment: 101583

Committed r91469: <http://trac.webkit.org/changeset/91469>
------- Comment #6 From 2011-07-21 08:12:23 PST -------
All reviewed patches have been landed.  Closing bug.