This is part 1 of a 3 part migration for bug 57261 to migrate to GraphicsContext3DOpenGL.cpp for Qt. Part 1 adopts existing GraphicsContext3D members for Qt. Move member vars and their initialization, and the GraphicsContext3DInternal::reshape() method out of GraphicsContext3DInternal and into GraphicsContext3D where they will be used when we adopt GraphicsContext3DOpenGL.cpp
Created attachment 101483 [details] adopt GraphicsContext3D members
Comment on attachment 101483 [details] adopt GraphicsContext3D members View in context: https://bugs.webkit.org/attachment.cgi?id=101483&action=review The code changes are good. Please resubmit with a more informative ChangeLog. > Source/WebCore/ChangeLog:8 > + Existing webgl layout tests should test this. WebGL, not webgl. > Source/WebCore/ChangeLog:11 > + where they will be needed when we adopt GraphicsContext3DOpenGL.cpp Missing a period, this upsets some people :)
Created attachment 101583 [details] update ChangeLog
Comment on attachment 101583 [details] update ChangeLog LGTM
Comment on attachment 101583 [details] update ChangeLog Clearing flags on attachment: 101583 Committed r91469: <http://trac.webkit.org/changeset/91469>
All reviewed patches have been landed. Closing bug.