Bug 64877 - [Qt] Adopt existing GraphicsContext3D members (part 1)
: [Qt] Adopt existing GraphicsContext3D members (part 1)
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebKit Qt
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks: 57261 64878
  Show dependency treegraph
 
Reported: 2011-07-20 10:10 PDT by Andrew Wason
Modified: 2011-07-21 08:12 PDT (History)
1 user (show)

See Also:


Attachments
adopt GraphicsContext3D members (21.97 KB, patch)
2011-07-20 10:42 PDT, Andrew Wason
noam: review-
Details | Formatted Diff | Diff
update ChangeLog (22.19 KB, patch)
2011-07-21 07:03 PDT, Andrew Wason
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Wason 2011-07-20 10:10:59 PDT
This is part 1 of a 3 part migration for bug 57261 to migrate to GraphicsContext3DOpenGL.cpp for Qt.

Part 1 adopts existing GraphicsContext3D members for Qt. Move member vars and their initialization,
and the GraphicsContext3DInternal::reshape() method out of GraphicsContext3DInternal and into
GraphicsContext3D where they will be used when we adopt GraphicsContext3DOpenGL.cpp
Comment 1 Andrew Wason 2011-07-20 10:42:22 PDT
Created attachment 101483 [details]
adopt GraphicsContext3D members
Comment 2 Noam Rosenthal 2011-07-21 01:48:33 PDT
Comment on attachment 101483 [details]
adopt GraphicsContext3D members

View in context: https://bugs.webkit.org/attachment.cgi?id=101483&action=review

The code changes are good. Please resubmit with a more informative ChangeLog.

> Source/WebCore/ChangeLog:8
> +        Existing webgl layout tests should test this.

WebGL, not webgl.

> Source/WebCore/ChangeLog:11
> +        where they will be needed when we adopt GraphicsContext3DOpenGL.cpp

Missing a period, this upsets some people :)
Comment 3 Andrew Wason 2011-07-21 07:03:20 PDT
Created attachment 101583 [details]
update ChangeLog
Comment 4 Noam Rosenthal 2011-07-21 07:13:41 PDT
Comment on attachment 101583 [details]
update ChangeLog

LGTM
Comment 5 WebKit Review Bot 2011-07-21 08:12:19 PDT
Comment on attachment 101583 [details]
update ChangeLog

Clearing flags on attachment: 101583

Committed r91469: <http://trac.webkit.org/changeset/91469>
Comment 6 WebKit Review Bot 2011-07-21 08:12:23 PDT
All reviewed patches have been landed.  Closing bug.