Bug 64867 - [GTK] REGRESSION(r86436): does not add newlines when return is pressed with some modifiers held
Summary: [GTK] REGRESSION(r86436): does not add newlines when return is pressed with s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gustavo Noronha (kov)
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2011-07-20 06:22 PDT by Gustavo Noronha (kov)
Modified: 2011-07-20 10:59 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.92 KB, patch)
2011-07-20 06:48 PDT, Gustavo Noronha (kov)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2011-07-20 06:22:06 PDT
My laptop (a lenovo x200s) seems to have numlock in an always-on state; I noticed that after that revision (I bisected), enter no longer generates new lines on any textareas. It is caused apparently by the fact that numlock is on. You can reproduce it in normal keyboards by turning capslock on.
Comment 1 Gustavo Noronha (kov) 2011-07-20 06:48:47 PDT
Created attachment 101464 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2011-07-20 06:49:55 PDT
Comment on attachment 101464 [details]
Patch

How about this? Makes it simpler and should work regardless of what modifiers are on =P
Comment 3 Martin Robinson 2011-07-20 09:38:34 PDT
Comment on attachment 101464 [details]
Patch

Nice! We may need to backport this to the stable branch.
Comment 4 WebKit Review Bot 2011-07-20 09:52:26 PDT
Comment on attachment 101464 [details]
Patch

Clearing flags on attachment: 101464

Committed r91376: <http://trac.webkit.org/changeset/91376>
Comment 5 WebKit Review Bot 2011-07-20 09:52:31 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Gustavo Noronha (kov) 2011-07-20 10:15:20 PDT
(In reply to comment #3)
> (From update of attachment 101464 [details])
> Nice! We may need to backport this to the stable branch.

The stable branch didn't have the patch that caused the regression on it, which means it's key bindings code is very, very different to what we have now in trunk, plus it doesn't have the regression, so I'd recommend against this =)
Comment 7 Martin Robinson 2011-07-20 10:59:18 PDT
(In reply to comment #6)
> (In reply to comment #3)
> > (From update of attachment 101464 [details] [details])
> > Nice! We may need to backport this to the stable branch.
> 
> The stable branch didn't have the patch that caused the regression on it, which means it's key bindings code is very, very different to what we have now in trunk, plus it doesn't have the regression, so I'd recommend against this =)

Even better!