Bug 64864 – Web Inspector: add shortcuts to load/save operations in Timeline panel

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Ilya Tikhonovsky]

%subj%

[Ilya Tikhonovsky]

Created attachment 101456 [details]
[patch] initial version

Export/import were renamed to save/load.
Ctrl|Meta-S/Ctrl|Meta-O shortcuts were added for Save and Load operations.
Ctrl|Meta-E shortcut toggles Record button;
Ctrl|Meta-H shortcut toggles short records filter button;
All the shortcuts were added to the shortcuts help screen.
There was a problem with saving empty data.

[Yury Semikhatsky]

Comment on attachment 101456 [details]
[patch] initial version

View in context: https://bugs.webkit.org/attachment.cgi?id=101456&action=review

> Source/WebCore/inspector/front-end/KeyboardShortcut.js:138
> +    return WebInspector.KeyboardShortcut._modifiersToString(key >> 8) + WebInspector.KeyboardShortcut._keyName(key & 255);

Delete this?

> Source/WebCore/inspector/front-end/TimelinePanel.js:236
> +        section.addKey(shortcut.shortcutToString("h", modifiers.CtrlOrMeta), WebInspector.UIString("Hide/show the records that are shorter than %s", shortRecordThresholdTitle));

Meta+h will hide browser window, won't it?

[Ilya Tikhonovsky]

Created attachment 101468 [details]
[patch] second version

Ctrl|Meta-Shift-F shortcut toggles short records filter button

[Yury Semikhatsky]

Comment on attachment 101468 [details]
[patch] second version

View in context: https://bugs.webkit.org/attachment.cgi?id=101468&action=review

> Source/WebCore/inspector/front-end/TimelinePanel.js:1301
> +        else

I'd rather put all records into the array first and then add '[' to the first record and ']' to the last one.

[Ilya Tikhonovsky]

Committed r91367: <http://trac.webkit.org/changeset/91367>