Bug 64864 - Web Inspector: add shortcuts to load/save operations in Timeline panel
Summary: Web Inspector: add shortcuts to load/save operations in Timeline panel
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-20 05:16 PDT by Ilya Tikhonovsky
Modified: 2011-07-20 08:44 PDT (History)
10 users (show)

See Also:


Attachments
[patch] initial version (12.18 KB, patch)
2011-07-20 06:20 PDT, Ilya Tikhonovsky
yurys: review-
Details | Formatted Diff | Diff
[patch] second version (11.75 KB, patch)
2011-07-20 07:34 PDT, Ilya Tikhonovsky
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2011-07-20 05:16:52 PDT
%subj%
Comment 1 Ilya Tikhonovsky 2011-07-20 06:20:05 PDT
Created attachment 101456 [details]
[patch] initial version

Export/import were renamed to save/load.
Ctrl|Meta-S/Ctrl|Meta-O shortcuts were added for Save and Load operations.
Ctrl|Meta-E shortcut toggles Record button;
Ctrl|Meta-H shortcut toggles short records filter button;
All the shortcuts were added to the shortcuts help screen.
There was a problem with saving empty data.
Comment 2 Yury Semikhatsky 2011-07-20 06:57:02 PDT
Comment on attachment 101456 [details]
[patch] initial version

View in context: https://bugs.webkit.org/attachment.cgi?id=101456&action=review

> Source/WebCore/inspector/front-end/KeyboardShortcut.js:138
> +    return WebInspector.KeyboardShortcut._modifiersToString(key >> 8) + WebInspector.KeyboardShortcut._keyName(key & 255);

Delete this?

> Source/WebCore/inspector/front-end/TimelinePanel.js:236
> +        section.addKey(shortcut.shortcutToString("h", modifiers.CtrlOrMeta), WebInspector.UIString("Hide/show the records that are shorter than %s", shortRecordThresholdTitle));

Meta+h will hide browser window, won't it?
Comment 3 Ilya Tikhonovsky 2011-07-20 07:34:16 PDT
Created attachment 101468 [details]
[patch] second version

Ctrl|Meta-Shift-F shortcut toggles short records filter button
Comment 4 Yury Semikhatsky 2011-07-20 08:08:19 PDT
Comment on attachment 101468 [details]
[patch] second version

View in context: https://bugs.webkit.org/attachment.cgi?id=101468&action=review

> Source/WebCore/inspector/front-end/TimelinePanel.js:1301
> +        else

I'd rather put all records into the array first and then add '[' to the first record and ']' to the last one.
Comment 5 Ilya Tikhonovsky 2011-07-20 08:44:12 PDT
Committed r91367: <http://trac.webkit.org/changeset/91367>