Bug 64857 – fast/speech/input-text-speechbutton.html is timing out after r91249

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Jeremy Moskovich]

Patch is in the works.

[Jeremy Moskovich]

Chromium bug: crbug.com/89717

[Jeremy Moskovich]

Created attachment 101447 [details]
Patch

[Satish Sampath]

Comment on attachment 101447 [details]
Patch

Looks good.

[Kent Tamura]

Comment on attachment 101447 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101447&action=review

ok!

> LayoutTests/fast/speech/input-text-speechbutton.html:16
> +    var isRTL = input.dir == 'rtl';

This doesn't work for CSS direction:rtl, but it's ok for testing.

[WebKit Review Bot]

Comment on attachment 101447 [details]
Patch

Rejecting attachment 101447 [details] from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[WebKit Review Bot]

Comment on attachment 101447 [details]
Patch

Attachment 101447 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9191221

New failing tests:
fast/speech/input-text-speechbutton.html

[Ryosuke Niwa]

(In reply to comment #6)
> (From update of attachment 101447 [details])
> Attachment 101447 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/9191221
> 
> New failing tests:
> fast/speech/input-text-speechbutton.html

Odd. http://queues.webkit.org/results/9191221 doesn't says nothing of the kind :(

[WebKit Review Bot]

Comment on attachment 101447 [details]
Patch

Rejecting attachment 101447 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2

Last 500 characters of output:
 fast/forms/implicit-submission.html = TEXT PASS


Regressions: Unexpected text diff mismatch : (1)
  fast/speech/input-text-speechbutton.html = TEXT

Regressions: Unexpected image mismatch : (5)
  fast/text/atsui-multiple-renderers.html = IMAGE
  fast/text/international/danda-space.html = IMAGE
  fast/text/international/thai-baht-space.html = IMAGE
  fast/text/international/thai-line-breaks.html = IMAGE
  platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html = IMAGE



Full output: http://queues.webkit.org/results/9200374

[Jeremy Moskovich]

Created attachment 101563 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 101563 [details]
Patch for landing

Rejecting attachment 101563 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 1

Last 500 characters of output:
s/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Updating OpenSource
Current branch master is up to date.
Updating chromium port dependencies using gclient...

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/9192581

[Jeremy Moskovich]

Created attachment 101565 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 101565 [details]
Patch for landing

Clearing flags on attachment: 101565

Committed r91458: <http://trac.webkit.org/changeset/91458>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.