Bug 64849 - [Refactoring] Shadow inclusion cache should be managed by ShadowContentSelector
Summary: [Refactoring] Shadow inclusion cache should be managed by ShadowContentSelector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks: 64072
  Show dependency tree / graph
 
Reported: 2011-07-20 00:11 PDT by Hajime Morrita
Modified: 2011-07-21 02:39 PDT (History)
2 users (show)

See Also:

Attachments
Patch (22.84 KB, patch)
2011-07-20 00:32 PDT, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Patch (22.89 KB, patch)
2011-07-21 01:36 PDT, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2011-07-20 00:11:06 PDT 
This is another preparation for introducing TreeIterator
Comment 1 Hajime Morrita 2011-07-20 00:32:37 PDT 
Created attachment 101432 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2011-07-20 09:23:11 PDT 
Comment on attachment 101432 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101432&action=review

This is a great clean-up!

> Source/WebCore/dom/ShadowContentSelector.h:61
> +    { }

This looks a bit weird. Perhaps move definition out of decl, include at the bottom of the header?
Comment 3 Hajime Morrita 2011-07-21 01:34:42 PDT 
Comment on attachment 101432 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101432&action=review

>> Source/WebCore/dom/ShadowContentSelector.h:61
>> +    { }
> 
> This looks a bit weird. Perhaps move definition out of decl, include at the bottom of the header?

Thanks for review, Dimitri!
I'll give a non-inlined definition then land.
Comment 4 Hajime Morrita 2011-07-21 01:36:48 PDT 
Created attachment 101560 [details]
Patch
Comment 5 WebKit Review Bot 2011-07-21 02:39:52 PDT 
Comment on attachment 101560 [details]
Patch

Clearing flags on attachment: 101560

Committed r91453: <http://trac.webkit.org/changeset/91453>
Comment 6 WebKit Review Bot 2011-07-21 02:39:56 PDT 
All reviewed patches have been landed.  Closing bug.