Bug 64834 - [chromium] LayerRendererChromium shouldn't be a friend of RenderSurfaceChromium
Summary: [chromium] LayerRendererChromium shouldn't be a friend of RenderSurfaceChromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-19 15:57 PDT by James Robinson
Modified: 2011-07-19 17:07 PDT (History)
4 users (show)

See Also:


Attachments
Patch (23.62 KB, patch)
2011-07-19 16:02 PDT, James Robinson
kbr: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2011-07-19 15:57:19 PDT
[chromium] LayerRendererChromium shouldn't be a friend of RenderSurfaceChromium
Comment 1 James Robinson 2011-07-19 16:02:37 PDT
Created attachment 101404 [details]
Patch
Comment 2 James Robinson 2011-07-19 16:24:58 PDT
Miscellaneous small cleanup.  I have some follow-up plans in this area that will be a lot more interesting.
Comment 3 Kenneth Russell 2011-07-19 16:50:01 PDT
Comment on attachment 101404 [details]
Patch

Looks fine to me.
Comment 4 WebKit Review Bot 2011-07-19 17:03:03 PDT
Comment on attachment 101404 [details]
Patch

Rejecting attachment 101404 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 1

Last 500 characters of output:
irectory
Updating working directory
Processing patch 101404 from bug 64834.
ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Updating OpenSource
Current branch master is up to date.
Updating chromium port dependencies using gclient...

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/9209037
Comment 5 James Robinson 2011-07-19 17:07:34 PDT
I am not good at this new changelog format, I deleted the "Reviewed by " line :/.
Comment 6 James Robinson 2011-07-19 17:07:57 PDT
Committed r91322: <http://trac.webkit.org/changeset/91322>