Bug 64832 – fix links on the flakiness dashboard

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ojan Vafai]

fix links on the flakiness dashboard

[Ojan Vafai]

Created attachment 101401 [details]
Patch

[Tony Chang]

Comment on attachment 101401 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101401&action=review

> Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:-1329
> -function showPopupForTest(e, test)
> -{
> -    showPopup(e, htmlForIndividulTestOnAllBuilders(test));
> -    appendExpectations();
> -}

Are you just removing dead code here?

> Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:1756
> +    // FIXME: Make this DOM creation less verbose.
> +    var index = document.createElement('div');
> +    index.style.cssFloat = 'right';
> +    index.textContent = (g_currentState.updateIndex + 1) + ' of ' + keys.length + ' tests';
> +    document.body.appendChild(index);

Maybe mention this refactoring in the ChangeLog?

[Ojan Vafai]

(In reply to comment #2)
> (From update of attachment 101401 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=101401&action=review
> 
> > Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:-1329
> > -function showPopupForTest(e, test)
> > -{
> > -    showPopup(e, htmlForIndividulTestOnAllBuilders(test));
> > -    appendExpectations();
> > -}
> 
> Are you just removing dead code here?

yes

> > Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:1756
> > +    // FIXME: Make this DOM creation less verbose.
> > +    var index = document.createElement('div');
> > +    index.style.cssFloat = 'right';
> > +    index.textContent = (g_currentState.updateIndex + 1) + ' of ' + keys.length + ' tests';
> > +    document.body.appendChild(index);
> 
> Maybe mention this refactoring in the ChangeLog?

k

[Ojan Vafai]

Committed r91518: <http://trac.webkit.org/changeset/91518>