Bug 64832 - fix links on the flakiness dashboard
Summary: fix links on the flakiness dashboard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-19 15:38 PDT by Ojan Vafai
Modified: 2011-07-21 15:13 PDT (History)
1 user (show)

See Also:

Attachments
Patch (3.73 KB, patch)
2011-07-19 15:39 PDT, Ojan Vafai 		tony: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2011-07-19 15:38:16 PDT 
fix links on the flakiness dashboard
Comment 1 Ojan Vafai 2011-07-19 15:39:07 PDT 
Created attachment 101401 [details]
Patch
Comment 2 Tony Chang 2011-07-19 16:32:53 PDT 
Comment on attachment 101401 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101401&action=review

> Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:-1329
> -function showPopupForTest(e, test)
> -{
> -    showPopup(e, htmlForIndividulTestOnAllBuilders(test));
> -    appendExpectations();
> -}

Are you just removing dead code here?

> Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:1756
> +    // FIXME: Make this DOM creation less verbose.
> +    var index = document.createElement('div');
> +    index.style.cssFloat = 'right';
> +    index.textContent = (g_currentState.updateIndex + 1) + ' of ' + keys.length + ' tests';
> +    document.body.appendChild(index);

Maybe mention this refactoring in the ChangeLog?
Comment 3 Ojan Vafai 2011-07-21 15:11:58 PDT 
(In reply to comment #2)
> (From update of attachment 101401 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=101401&action=review
> 
> > Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:-1329
> > -function showPopupForTest(e, test)
> > -{
> > -    showPopup(e, htmlForIndividulTestOnAllBuilders(test));
> > -    appendExpectations();
> > -}
> 
> Are you just removing dead code here?

yes

> > Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:1756
> > +    // FIXME: Make this DOM creation less verbose.
> > +    var index = document.createElement('div');
> > +    index.style.cssFloat = 'right';
> > +    index.textContent = (g_currentState.updateIndex + 1) + ' of ' + keys.length + ' tests';
> > +    document.body.appendChild(index);
> 
> Maybe mention this refactoring in the ChangeLog?

k
Comment 4 Ojan Vafai 2011-07-21 15:13:42 PDT 
Committed r91518: <http://trac.webkit.org/changeset/91518>