Bug 64821 - cleanup some of the PLATFORM logic in the flakiness dashboard
Summary: cleanup some of the PLATFORM logic in the flakiness dashboard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks: 64829
  Show dependency treegraph
 
Reported: 2011-07-19 13:40 PDT by Ojan Vafai
Modified: 2011-07-19 15:46 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.97 KB, patch)
2011-07-19 13:40 PDT, Ojan Vafai
no flags Details | Formatted Diff | Diff
Patch (4.96 KB, patch)
2011-07-19 13:42 PDT, Ojan Vafai
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2011-07-19 13:40:10 PDT
cleanup some of the PLATFORM logic in the flakiness dashboard
Comment 1 Ojan Vafai 2011-07-19 13:40:43 PDT
Created attachment 101374 [details]
Patch
Comment 2 Ojan Vafai 2011-07-19 13:42:21 PDT
Created attachment 101376 [details]
Patch
Comment 3 Adam Barth 2011-07-19 15:26:12 PDT
Comment on attachment 101376 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101376&action=review

> Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:1688
>  function realModifiers(modifierString)

"real" modifiers?  As opposed to fictions modifiers?
Comment 4 Ojan Vafai 2011-07-19 15:45:27 PDT
(In reply to comment #3)
> (From update of attachment 101376 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=101376&action=review
> 
> > Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:1688
> >  function realModifiers(modifierString)
> 
> "real" modifiers?  As opposed to fictions modifiers?

Sigh. I know. The comment clarifies what it means. I tried and failed to think of a better name.
Comment 5 Ojan Vafai 2011-07-19 15:46:40 PDT
Committed r91312: <http://trac.webkit.org/changeset/91312>