Bug 64818 - Remove surfaceType() and texture() methods from Chromium video frame classes.
Summary: Remove surfaceType() and texture() methods from Chromium video frame classes.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andrew Scherkus
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-19 13:25 PDT by Andrew Scherkus
Modified: 2011-07-22 12:07 PDT (History)
3 users (show)

See Also:

Attachments
Patch (9.29 KB, patch)
2011-07-19 13:27 PDT, Andrew Scherkus 		no flags Details | Formatted Diff | Diff
Patch (9.30 KB, patch)
2011-07-19 13:35 PDT, Andrew Scherkus 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Scherkus 2011-07-19 13:25:57 PDT 
Remove surfaceType() and texture() methods from Chromium video frame classes.
Comment 1 Andrew Scherkus 2011-07-19 13:27:39 PDT 
Created attachment 101369 [details]
Patch
Comment 2 WebKit Review Bot 2011-07-19 13:30:11 PDT 
Attachment 101369 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andrew Scherkus 2011-07-19 13:35:12 PDT 
Created attachment 101372 [details]
Patch
Comment 4 Andrew Scherkus 2011-07-22 10:33:12 PDT 
cc'ing graphics-y folk
Comment 5 Kenneth Russell 2011-07-22 11:12:03 PDT 
Comment on attachment 101372 [details]
Patch

Looks fine as long as it's been tested.
Comment 6 Andrew Scherkus 2011-07-22 11:34:25 PDT 
Comment on attachment 101372 [details]
Patch

thanks for the review!

yeah just getting rid of potentially-confusing dead code
Comment 7 WebKit Review Bot 2011-07-22 12:07:55 PDT 
Comment on attachment 101372 [details]
Patch

Clearing flags on attachment: 101372

Committed r91584: <http://trac.webkit.org/changeset/91584>
Comment 8 WebKit Review Bot 2011-07-22 12:07:59 PDT 
All reviewed patches have been landed.  Closing bug.