Bug 64809 - REGRESSION (r91114-r91116): fast/dom/error-to-string-stack-overflow.html failing on Windows 7 Release (Tests)
Summary: REGRESSION (r91114-r91116): fast/dom/error-to-string-stack-overflow.html fail...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL: http://build.webkit.org/results/Windo...
Keywords: LayoutTestFailure, MakingBotsRed, Regression
Depends on:
Reported: 2011-07-19 09:49 PDT by Adam Roben (:aroben)
Modified: 2011-07-19 14:51 PDT (History)
2 users (show)

See Also:

The patch (1.70 KB, patch)
2011-07-19 14:49 PDT, Gavin Barraclough
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-07-19 09:49:08 PDT
fast/dom/error-to-string-stack-overflow.html started failing on Windows 7 Release (Tests) between r91115 and r91116 (inclusive).


http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r91114%20(14819)/results.html passed
http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r91116%20(14820)/results.html failed
Comment 1 Gavin Barraclough 2011-07-19 12:21:44 PDT
Comment 2 Gavin Barraclough 2011-07-19 14:41:23 PDT
I think this just needs new results.  The test deliberately triggers a stack overflow, and doesn't catch it, so the error is printed to the console.  Previously RangeError had the wrong prototype, and didn't convert the error into a useful error message, printing a blank line in the console.  Since r91116 we inherit from Error correctly, and print the error to the console.
Comment 3 Adam Roben (:aroben) 2011-07-19 14:46:43 PDT
Thanks for the analysis, Gavin. Could you update the results by grabbing them from the bot? "webkit-patch rebaseline" might be the easiest way.
Comment 4 Gavin Barraclough 2011-07-19 14:49:54 PDT
Created attachment 101391 [details]
The patch
Comment 5 Gavin Barraclough 2011-07-19 14:51:47 PDT
Fixed in r91305