REGRESSION (r91114-r91116): fast/dom/error-to-string-stack-overflow.html failing on Windows 7 Release (Tests)

[Adam Roben (:aroben)]

fast/dom/error-to-string-stack-overflow.html started failing on Windows 7 Release (Tests) between r91115 and r91116 (inclusive).

http://trac.webkit.org/log/trunk?rev=91116&stop_rev=91115

http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r91114%20(14819)/results.html passed
http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r91116%20(14820)/results.html failed

[Gavin Barraclough]

investigating.

[Gavin Barraclough]

I think this just needs new results.  The test deliberately triggers a stack overflow, and doesn't catch it, so the error is printed to the console.  Previously RangeError had the wrong prototype, and didn't convert the error into a useful error message, printing a blank line in the console.  Since r91116 we inherit from Error correctly, and print the error to the console.

[Adam Roben (:aroben)]

Thanks for the analysis, Gavin. Could you update the results by grabbing them from the bot? "webkit-patch rebaseline" might be the easiest way.

[Gavin Barraclough]

Created attachment 101391 [details]
The patch

[Gavin Barraclough]

Fixed in r91305