Bug 64803 - [Qt] Reapply the change that removes C++0x mode from QtWebKit
Summary: [Qt] Reapply the change that removes C++0x mode from QtWebKit
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-07-19 09:02 PDT by Thiago Macieira
Modified: 2014-02-03 03:18 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.09 KB, patch)
2011-07-19 09:04 PDT, Thiago Macieira 		benjamin: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Macieira 2011-07-19 09:02:38 PDT 
Reapply the change that removes C++0x mode from QtWebKit
Comment 1 Thiago Macieira 2011-07-19 09:04:57 PDT 
Created attachment 101326 [details]
Patch
Comment 2 Ademar Reis 2011-07-21 11:59:04 PDT 
Comment on attachment 101326 [details]
Patch

You need a changelog (from prepare-Changelog or webkit-patch upload) before the patch gets a r+. (no r- from me because I'm not a reviewer)
Comment 3 Thiago Macieira 2011-07-21 12:17:16 PDT 
Is there a script that creates a changelog?
Comment 4 Benjamin Poulain 2011-08-16 06:26:13 PDT 
Hey Thiago, sorry your patch was ignored.

We usually use prefix or keywords to filter the reviews for Qt. When you submit a patch, you can put the whole team in the CC list so one of review quickly.

(In reply to comment #3)
> Is there a script that creates a changelog?

./Tools/Script/prepare-changelog --bug 64803
Comment 5 Benjamin Poulain 2011-08-16 06:26:55 PDT 
Comment on attachment 101326 [details]
Patch

Missing Changelog explaining the change
Comment 6 Alexis Menard (darktears) 2011-08-17 10:53:48 PDT 
Comment on attachment 101326 [details]
Patch

I don't like the change as it doesn't help WebKit in general to support C++11 but rather workaround the problem. I think to me this should not be in trunk but rather in Qt 4.8/QtWebKit 2.2 for now.
Comment 7 Jocelyn Turcotte 2014-02-03 03:18:17 PST 
=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.