RESOLVED INVALID 64803
[Qt] Reapply the change that removes C++0x mode from QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=64803
Summary [Qt] Reapply the change that removes C++0x mode from QtWebKit
Thiago Macieira
Reported 2011-07-19 09:02:38 PDT
Reapply the change that removes C++0x mode from QtWebKit
Attachments
Patch (2.09 KB, patch)
2011-07-19 09:04 PDT, Thiago Macieira
benjamin: review-
Thiago Macieira
Comment 1 2011-07-19 09:04:57 PDT
Ademar Reis
Comment 2 2011-07-21 11:59:04 PDT
Comment on attachment 101326 [details] Patch You need a changelog (from prepare-Changelog or webkit-patch upload) before the patch gets a r+. (no r- from me because I'm not a reviewer)
Thiago Macieira
Comment 3 2011-07-21 12:17:16 PDT
Is there a script that creates a changelog?
Benjamin Poulain
Comment 4 2011-08-16 06:26:13 PDT
Hey Thiago, sorry your patch was ignored. We usually use prefix or keywords to filter the reviews for Qt. When you submit a patch, you can put the whole team in the CC list so one of review quickly. (In reply to comment #3) > Is there a script that creates a changelog? ./Tools/Script/prepare-changelog --bug 64803
Benjamin Poulain
Comment 5 2011-08-16 06:26:55 PDT
Comment on attachment 101326 [details] Patch Missing Changelog explaining the change
Alexis Menard (darktears)
Comment 6 2011-08-17 10:53:48 PDT
Comment on attachment 101326 [details] Patch I don't like the change as it doesn't help WebKit in general to support C++11 but rather workaround the problem. I think to me this should not be in trunk but rather in Qt 4.8/QtWebKit 2.2 for now.
Jocelyn Turcotte
Comment 7 2014-02-03 03:18:17 PST
=== Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.
Note You need to log in before you can comment on or make changes to this bug.