Bug 64800 - Store line number on TestExpectationLine.
Summary: Store line number on TestExpectationLine.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks: 64385
  Show dependency treegraph
 
Reported: 2011-07-19 08:50 PDT by Dimitri Glazkov (Google)
Modified: 2011-07-19 15:45 PDT (History)
2 users (show)

See Also:


Attachments
Patch (8.37 KB, patch)
2011-07-19 08:51 PDT, Dimitri Glazkov (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-07-19 08:50:10 PDT
Store line number on TestExpectationLine.
Comment 1 Dimitri Glazkov (Google) 2011-07-19 08:51:35 PDT
Created attachment 101325 [details]
Patch
Comment 2 Adam Barth 2011-07-19 15:19:08 PDT
Comment on attachment 101325 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101325&action=review

> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:316
> +        line_number = 0
>          for line in expectations_string.split("\n"):
> -            expectation_lines.append(cls.tokenize(line))
> +            line_number += 1

No enumerate?
Comment 3 Dimitri Glazkov (Google) 2011-07-19 15:19:50 PDT
Comment on attachment 101325 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101325&action=review

>> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:316
>> +            line_number += 1
> 
> No enumerate?

Not while we're running Python 2.5.
Comment 4 Adam Barth 2011-07-19 15:33:38 PDT
Comment on attachment 101325 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101325&action=review

>>> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:316
>>> +            line_number += 1
>> 
>> No enumerate?
> 
> Not while we're running Python 2.5.

2.5 => frowns.
Comment 5 WebKit Review Bot 2011-07-19 15:45:10 PDT
Comment on attachment 101325 [details]
Patch

Clearing flags on attachment: 101325

Committed r91311: <http://trac.webkit.org/changeset/91311>
Comment 6 WebKit Review Bot 2011-07-19 15:45:15 PDT
All reviewed patches have been landed.  Closing bug.