RESOLVED FIXED64800
Store line number on TestExpectationLine. 
https://bugs.webkit.org/show_bug.cgi?id=64800
Summary Store line number on TestExpectationLine.
Dimitri Glazkov (Google)
Reported 2011-07-19 08:50:10 PDT
Store line number on TestExpectationLine.
Attachments
Patch (8.37 KB, patch)
2011-07-19 08:51 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-07-19 08:51:35 PDT
Created attachment 101325 [details] Patch
Adam Barth
Comment 2 2011-07-19 15:19:08 PDT
Comment on attachment 101325 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101325&action=review > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:316 > + line_number = 0 > for line in expectations_string.split("\n"): > - expectation_lines.append(cls.tokenize(line)) > + line_number += 1 No enumerate?
Dimitri Glazkov (Google)
Comment 3 2011-07-19 15:19:50 PDT
Comment on attachment 101325 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101325&action=review >> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:316 >> + line_number += 1 > > No enumerate? Not while we're running Python 2.5.
Adam Barth
Comment 4 2011-07-19 15:33:38 PDT
Comment on attachment 101325 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101325&action=review >>> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:316 >>> + line_number += 1 >> >> No enumerate? > > Not while we're running Python 2.5. 2.5 => frowns.
WebKit Review Bot
Comment 5 2011-07-19 15:45:10 PDT
Comment on attachment 101325 [details] Patch Clearing flags on attachment: 101325 Committed r91311: <http://trac.webkit.org/changeset/91311>
WebKit Review Bot
Comment 6 2011-07-19 15:45:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.