Bug 64795 - update FontSkia to match platform context convention
: update FontSkia to match platform context convention
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Cary Clark
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-19 06:24 PDT by Cary Clark
Modified: 2011-07-20 12:31 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.43 KB, patch)
2011-07-19 06:56 PDT, Cary Clark
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cary Clark 2011-07-19 06:24:05 PDT
update FontSkia to match platform context convention
Comment 1 Cary Clark 2011-07-19 06:56:50 PDT
Created attachment 101311 [details]
Patch
Comment 2 Eric Seidel 2011-07-19 12:31:19 PDT
Comment on attachment 101311 [details]
Patch

I'm not sure what this does.  I assume Skia changed their API?
Comment 3 Cary Clark 2011-07-19 13:41:48 PDT
Looks like jamesr renamed this in https://bugs.webkit.org/show_bug.cgi?id=64214
Comment 4 James Robinson 2011-07-19 14:31:59 PDT
Comment on attachment 101311 [details]
Patch

I'm surprised that WebKit compiles without this patch.  What's going on with this file?
Comment 5 Cary Clark 2011-07-20 04:46:11 PDT
This file is used to support running Skia on Chromium Mac port. It is compiled for now only when GYP_DEFINES="use_skia=1"
Comment 6 WebKit Review Bot 2011-07-20 12:31:21 PDT
Comment on attachment 101311 [details]
Patch

Clearing flags on attachment: 101311

Committed r91388: <http://trac.webkit.org/changeset/91388>
Comment 7 WebKit Review Bot 2011-07-20 12:31:27 PDT
All reviewed patches have been landed.  Closing bug.