Bug 64794 – MediaStream API: Merging MediaStreamContainer and MediaStreamList

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Tommy Widenflycht]

Having a separate container class doesn't make any sense.

[Tommy Widenflycht]

Created attachment 101308 [details]
Patch

[Tony Gentilcore]

Comment on attachment 101308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101308&action=review

Thanks for the cleanup. Just a nit about includes to address before submission.

> Source/WebCore/dom/MediaStreamList.h:30
> +#include "MediaStream.h"

Is this really necessary here? At first glance it seems like the forward declaration should suffice. If it is necessary, please remove the forward declaration, otherwise please add this in the cpp.

[Tommy Widenflycht]

Comment on attachment 101308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101308&action=review

>> Source/WebCore/dom/MediaStreamList.h:30
>> +#include "MediaStream.h"
> 
> Is this really necessary here? At first glance it seems like the forward declaration should suffice. If it is necessary, please remove the forward declaration, otherwise please add this in the cpp.

It seems to be, the hashmap goes nuts without a real implementation.

Have removed the forward definition of MediaStream.

[Tommy Widenflycht]

Created attachment 101466 [details]
Patch

[WebKit Review Bot]

Comment on attachment 101466 [details]
Patch

Rejecting attachment 101466 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2

Last 500 characters of output:
-14 lines).
Hunk #4 succeeded at 22238 (offset -18 lines).
2 out of 4 hunks FAILED -- saving rejects to file Source/WebCore/WebCore.xcodeproj/project.pbxproj.rej
patching file Source/WebCore/dom/MediaStreamContainer.h
rm 'Source/WebCore/dom/MediaStreamContainer.h'
patching file Source/WebCore/dom/MediaStreamList.cpp
patching file Source/WebCore/dom/MediaStreamList.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Tony Gentilcore', u'--..." exit_code: 1

Full output: http://queues.webkit.org/results/9209261

[Tommy Widenflycht]

Created attachment 101561 [details]
Patch

Rebase

[WebKit Review Bot]

Comment on attachment 101561 [details]
Patch

Clearing flags on attachment: 101561

Committed r91455: <http://trac.webkit.org/changeset/91455>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.