Bug 64765 - add new flexbox data to StyleRareNonInheritedData
Summary: add new flexbox data to StyleRareNonInheritedData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks: 64038
  Show dependency tree / graph
 
Reported: 2011-07-18 16:48 PDT by Tony Chang
Modified: 2011-07-20 14:27 PDT (History)
5 users (show)

See Also:

Attachments
Patch (25.56 KB, patch)
2011-07-18 16:51 PDT, Tony Chang 		no flags Details | Formatted Diff | Diff
Patch for landing (25.49 KB, patch)
2011-07-20 11:53 PDT, Tony Chang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2011-07-18 16:48:42 PDT 
add new flexbox data to StyleRareNonInheritedData
Comment 1 Tony Chang 2011-07-18 16:51:35 PDT 
Created attachment 101235 [details]
Patch
Comment 2 Dave Hyatt 2011-07-20 11:42:36 PDT 
Comment on attachment 101235 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101235&action=review

r=me. One small nit.

> Source/WebCore/rendering/style/RenderStyle.h:1313
> +    static float initialFlexboxWidthPositiveFlex() { return 0.0; }
> +    static float initialFlexboxWidthNegativeFlex() { return 0.0; }
> +    static float initialFlexboxHeightPositiveFlex() { return 0.0; }
> +    static float initialFlexboxHeightNegativeFlex() { return 0.0; }

You can actually just say "0" here. You don't have to say "0.0"
Comment 3 Tony Chang 2011-07-20 11:53:59 PDT 
Created attachment 101490 [details]
Patch for landing
Comment 4 WebKit Review Bot 2011-07-20 13:06:14 PDT 
Comment on attachment 101490 [details]
Patch for landing

Clearing flags on attachment: 101490

Committed r91392: <http://trac.webkit.org/changeset/91392>
Comment 5 WebKit Review Bot 2011-07-20 13:06:19 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Andy Estes 2011-07-20 14:10:14 PDT 
Fixed the Mac build in <http://trac.webkit.org/changeset/91402>.
Comment 7 Tony Chang 2011-07-20 14:16:20 PDT 
(In reply to comment #6)
> Fixed the Mac build in <http://trac.webkit.org/changeset/91402>.

Thanks for fixing!  Do you know why the ews bot didn't complain?
Comment 8 Andy Estes 2011-07-20 14:23:50 PDT 
(In reply to comment #7)
> (In reply to comment #6)
> > Fixed the Mac build in <http://trac.webkit.org/changeset/91402>.
> 
> Thanks for fixing!  Do you know why the ews bot didn't complain?

np!

I think EWS bots only do incremental recompiles, so since you didn't touch any downstream code that relies on WebCore's forwarding headers (e.g. WebKit), you didn't see the error. I just happened to do a clean build this morning.
Comment 9 Andy Estes 2011-07-20 14:27:32 PDT 
Although on second thought, you did touch RenderStyle.h which was already a forwarded header, so that should have caused some WebKit code to recompile. So it's unclear to me why EWS didn't catch it, given this. Does the Mac EWS bot no longer compile the Apple port or something?