add new flexbox data to StyleRareNonInheritedData
Created attachment 101235 [details] Patch
Comment on attachment 101235 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101235&action=review r=me. One small nit. > Source/WebCore/rendering/style/RenderStyle.h:1313 > + static float initialFlexboxWidthPositiveFlex() { return 0.0; } > + static float initialFlexboxWidthNegativeFlex() { return 0.0; } > + static float initialFlexboxHeightPositiveFlex() { return 0.0; } > + static float initialFlexboxHeightNegativeFlex() { return 0.0; } You can actually just say "0" here. You don't have to say "0.0"
Created attachment 101490 [details] Patch for landing
Comment on attachment 101490 [details] Patch for landing Clearing flags on attachment: 101490 Committed r91392: <http://trac.webkit.org/changeset/91392>
All reviewed patches have been landed. Closing bug.
Fixed the Mac build in <http://trac.webkit.org/changeset/91402>.
(In reply to comment #6) > Fixed the Mac build in <http://trac.webkit.org/changeset/91402>. Thanks for fixing! Do you know why the ews bot didn't complain?
(In reply to comment #7) > (In reply to comment #6) > > Fixed the Mac build in <http://trac.webkit.org/changeset/91402>. > > Thanks for fixing! Do you know why the ews bot didn't complain? np! I think EWS bots only do incremental recompiles, so since you didn't touch any downstream code that relies on WebCore's forwarding headers (e.g. WebKit), you didn't see the error. I just happened to do a clean build this morning.
Although on second thought, you did touch RenderStyle.h which was already a forwarded header, so that should have caused some WebKit code to recompile. So it's unclear to me why EWS didn't catch it, given this. Does the Mac EWS bot no longer compile the Apple port or something?