webkit-patch apply-attachment does not work when not called from the root of the checkout
Created attachment 101201 [details] Patch
Comment on attachment 101201 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101201&action=review > Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py:137 > - expected_stderr = "MOCK run_command: ['Tools/Scripts/build-dumprendertree', '--release']\n" > + expected_stderr = "MOCK run_command: ['Tools/Scripts/build-dumprendertree', '--release'], cwd=/mock\n" Can you rename /mock to /checkout-root? It's not obvious that what it is. > Tools/Scripts/webkitpy/tool/servers/gardeningserver.py:64 > - self.server.tool.executive.run_and_throw_if_fail(update_webkit_command, quiet=True) > + self.server.tool.executive.run_and_throw_if_fail(update_webkit_command, quiet=True, cwd=self.server.tool.scm().checkout_root) Its kind of lame that this is copy/pasted everywhere. Can't we have that be the default somehow? > Tools/Scripts/webkitpy/tool/steps/preparechangelog.py:76 > - self._tool.executive.run_and_throw_if_fail(args, self._options.quiet) > + self._tool.executive.run_and_throw_if_fail(args, self._options.quiet, cwd=self._tool.scm().checkout_root) Does this do the right thing if -d is specified? I guess _changed_files will make it work right.
Committed r91210: <http://trac.webkit.org/changeset/91210>