If CONTEXT_MENUS macro is disabled ewk_context_menu_destroy does nothing so it returns EINA_FALSE and omits NULL checking.
Created attachment 101139 [details] proposed patch
The ChangeLog entry sounds a bit confusing to me -- the one-line description looks like the method _currently_ does what is being described, not that this is what is being changed. I see that you are submitting a few separate patches related to context menus. Do you plan on adding these #if checks to the other functions in ewk_contextmenu.cpp?
(In reply to comment #2) > The ChangeLog entry sounds a bit confusing to me -- the one-line description looks like the method _currently_ does what is being described, not that this is what is being changed. > Ok, I will fix ChangeLog. > I see that you are submitting a few separate patches related to context menus. Do you plan on adding these #if checks to the other functions in ewk_contextmenu.cpp? I've sent two patches related to the context menu. First fixes build break, second one changes returned value. There aren't more references to WebCore's context menu object (controller) by API that are not surrounded by CONTEXT_MENUS macro. I don't think so others methods should check this macro. What is your opinion on that?
(In reply to comment #3) > > I see that you are submitting a few separate patches related to context menus. Do you plan on adding these #if checks to the other functions in ewk_contextmenu.cpp? > > I've sent two patches related to the context menu. First fixes build break, second one changes returned value. > There aren't more references to WebCore's context menu object (controller) by API that are not surrounded by CONTEXT_MENUS macro. I don't think so others methods should check this macro. What is your opinion on that? Let's not fix what's not broken ;) If the rest works, I think it's OK to leave it as it is.
Created attachment 101277 [details] ChangeLog fix
Attachment 101277 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/efl/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 101278 [details] ChangeLog fix Incorrect URL in the previous patch.
LGTM.
r+ from my side too.
Comment on attachment 101278 [details] ChangeLog fix Clearing flags on attachment: 101278 Committed r91658: <http://trac.webkit.org/changeset/91658>
All reviewed patches have been landed. Closing bug.