Bug 64682 - [EFL] Move macro checking inside ewk_view_context_menu_forward_event
Summary: [EFL] Move macro checking inside ewk_view_context_menu_forward_event
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-18 00:42 PDT by Grzegorz Czajkowski
Modified: 2011-08-12 00:52 PDT (History)
5 users (show)

See Also:


Attachments
proposed patch (1.82 KB, patch)
2011-07-18 00:44 PDT, Grzegorz Czajkowski
no flags Details | Formatted Diff | Diff
proposed patch (1.72 KB, patch)
2011-07-28 00:43 PDT, Grzegorz Czajkowski
kenneth: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
updated patch (1.55 KB, patch)
2011-08-02 23:50 PDT, Grzegorz Czajkowski
no flags Details | Formatted Diff | Diff
updated patch (1.57 KB, patch)
2011-08-11 23:45 PDT, Grzegorz Czajkowski
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Grzegorz Czajkowski 2011-07-18 00:42:24 PDT
When CONTEXT_MENUS macro is disabled method ewk_view_context_menu_forward_event just returns EINA_FALSE and it avoid undefined reference during building.
Comment 1 Grzegorz Czajkowski 2011-07-18 00:44:05 PDT
Created attachment 101136 [details]
proposed patch
Comment 2 Gyuyoung Kim 2011-07-18 00:59:37 PDT
LGTM.
Comment 3 Raphael Kubo da Costa (:rakuco) 2011-07-18 05:53:39 PDT
Informal r+ too.
Comment 4 WebKit Review Bot 2011-07-25 00:10:58 PDT
Comment on attachment 101136 [details]
proposed patch

Clearing flags on attachment: 101136

Committed r91659: <http://trac.webkit.org/changeset/91659>
Comment 5 WebKit Review Bot 2011-07-25 00:11:03 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Grzegorz Czajkowski 2011-07-28 00:41:34 PDT
This patch has been overwritten in r91815 by mistake.
Comment 7 Grzegorz Czajkowski 2011-07-28 00:43:11 PDT
Created attachment 102236 [details]
proposed patch

Restore patch for fix ewk_view_context_menu_forward_event which has been overwrititen by mistake.
Comment 8 Raphael Kubo da Costa (:rakuco) 2011-07-28 05:41:04 PDT
r+ again.
Comment 9 Kenneth Rohde Christiansen 2011-08-02 12:02:49 PDT
Comment on attachment 102236 [details]
proposed patch

LGTM
Comment 10 WebKit Review Bot 2011-08-02 12:33:26 PDT
Comment on attachment 102236 [details]
proposed patch

Rejecting attachment 102236 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 2

Last 500 characters of output:
h file(s).
patching file Source/WebKit/efl/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/efl/ewk/ewk_view.cpp
Hunk #1 FAILED at 1589.
Hunk #2 succeeded at 1396 with fuzz 1 (offset -205 lines).
Hunk #3 succeeded at 1425 with fuzz 2 (offset -205 lines).
1 out of 3 hunks FAILED -- saving rejects to file Source/WebKit/efl/ewk/ewk_view.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Kenneth Rohde Christia..." exit_code: 1

Full output: http://queues.webkit.org/results/9289742
Comment 11 Grzegorz Czajkowski 2011-08-02 23:50:59 PDT
Created attachment 102744 [details]
updated patch

Updated patch to the current changes.
Comment 12 Leandro Pereira 2011-08-03 08:21:37 PDT
Comment on attachment 102744 [details]
updated patch

LGTM.
Comment 13 Grzegorz Czajkowski 2011-08-11 23:45:54 PDT
Created attachment 103741 [details]
updated patch

Filled reviewer filed because this patch has been already reviewed.
Comment 14 Gyuyoung Kim 2011-08-11 23:53:00 PDT
Comment on attachment 103741 [details]
updated patch

LGTM.
Comment 15 WebKit Review Bot 2011-08-12 00:52:38 PDT
Comment on attachment 103741 [details]
updated patch

Clearing flags on attachment: 103741

Committed r92949: <http://trac.webkit.org/changeset/92949>
Comment 16 WebKit Review Bot 2011-08-12 00:52:43 PDT
All reviewed patches have been landed.  Closing bug.