Bug 64679 - Fix bugs in Array.prototype this handling.
Summary: Fix bugs in Array.prototype this handling.
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
: 65885 (view as bug list)
Depends on: 64250
  Show dependency treegraph
Reported: 2011-07-17 23:29 PDT by Gavin Barraclough
Modified: 2011-09-28 14:24 PDT (History)
5 users (show)

See Also:

Preliminary patch (8.89 KB, patch)
2011-07-17 23:31 PDT, Gavin Barraclough
no flags Details | Formatted Diff | Diff
The patch (23.10 KB, patch)
2011-07-19 11:48 PDT, Gavin Barraclough
oliver: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2011-07-17 23:29:04 PDT
undefined/null this values should throw TypeErrors, not convert to the global object.
Comment 1 Gavin Barraclough 2011-07-17 23:31:37 PDT
Created attachment 101131 [details]
Preliminary patch
Comment 2 Gavin Barraclough 2011-07-19 11:48:17 PDT
Created attachment 101353 [details]
The patch
Comment 3 WebKit Review Bot 2011-07-19 12:16:43 PDT
Comment on attachment 101353 [details]
The patch

Attachment 101353 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9159222

New failing tests:
Comment 4 Gavin Barraclough 2011-07-19 13:52:11 PDT
Fixed in r91290
Comment 5 Gavin Barraclough 2011-07-31 23:33:02 PDT
Rolled out in 92093.
This caused web compatibility issues, particularly with Mac App Store content.
Comment 6 Mark Hahnenberg 2011-08-09 09:51:31 PDT
*** Bug 65885 has been marked as a duplicate of this bug. ***
Comment 7 Gavin Barraclough 2011-09-28 12:02:12 PDT
Re-landed in r96243.
Comment 8 Adam Roben (:aroben) 2011-09-28 12:09:12 PDT
Is it possible to write a regression test for this?
Comment 9 Gavin Barraclough 2011-09-28 12:25:14 PDT
(In reply to comment #8)
> Is it possible to write a regression test for this?

Errrrrr, I did!  And when I rolled the patch out I left them in the tree.  So...

Ooops!, forgot to commit updated (passing) LayoutTest results, landed in r96246.
Comment 10 Darin Adler 2011-09-28 14:24:36 PDT
No test case?
Comment 11 Darin Adler 2011-09-28 14:24:50 PDT
(In reply to comment #10)
> No test case?

LOL, I see the earlier comments now.