Bug 64677 - Fix bugs in String.prototype this handling.
: Fix bugs in String.prototype this handling.
Status: RESOLVED FIXED
: WebKit
JavaScriptCore
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
: 64250
:
  Show dependency treegraph
 
Reported: 2011-07-17 23:28 PST by
Modified: 2012-07-06 01:40 PST (History)


Attachments
Preliminary patch (12.64 KB, patch)
2011-07-17 23:31 PST, Gavin Barraclough
no flags Review Patch | Details | Formatted Diff | Diff
The patch (18.44 KB, patch)
2011-07-19 11:47 PST, Gavin Barraclough
oliver: review+
webkit.review.bot: commit‑queue-
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-07-17 23:28:58 PST
undefined/null this values should throw TypeErrors, not convert to the global object, and primitive values should not be converted via object types.
------- Comment #1 From 2011-07-17 23:31:18 PST -------
Created an attachment (id=101130) [details]
Preliminary patch
------- Comment #2 From 2011-07-19 11:47:48 PST -------
Created an attachment (id=101352) [details]
The patch
------- Comment #3 From 2011-07-19 12:12:23 PST -------
(From update of attachment 101352 [details])
Attachment 101352 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9153271

New failing tests:
fast/js/array-prototype-properties.html
------- Comment #4 From 2011-07-19 12:16:47 PST -------
Fixed in r91284