Bug 64675 - [SVG] [Chromium] zero-path-square-cap-rendering.svg is failing
Summary: [SVG] [Chromium] zero-path-square-cap-rendering.svg is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Stephen Chenney
URL:
Keywords:
Depends on: 71820
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-17 21:59 PDT by Ryosuke Niwa
Modified: 2012-01-25 19:47 PST (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Comment 3 Ryosuke Niwa 2011-07-18 13:41:12 PDT
Nope.  They're still failing :(  This might be Skia related.
Comment 4 Ryosuke Niwa 2011-07-18 14:27:15 PDT
Committed r91211: <http://trac.webkit.org/changeset/91211>
Comment 5 Ryosuke Niwa 2011-07-18 14:27:54 PDT
svg/W3C-SVG-1.1-SE/painting-control-04-f.svg is now passing but zero-path-square-cap-rendering.svg is not.
Comment 6 Rob Buis 2011-07-18 14:49:49 PDT
Hi,

(In reply to comment #5)
> svg/W3C-SVG-1.1-SE/painting-control-04-f.svg is now passing but zero-path-square-cap-rendering.svg is not.

For anyone looking into the problem on chromium, one thing to check first is check that the m_fillBoundingBox width and height is really zero. This comes from Path which is platform specific. So, the question is what Skia returns for bbox of a path "M 100 100 Z", if width/height is not exactly zero, the new special handling of zero-length paths will not kick in.
Cheers,

Rob.
Comment 7 Stephen Chenney 2011-12-07 12:39:25 PST
This is Skia 398: http://code.google.com/p/skia/issues/detail?id=398

Skia throws away the closing "z" in "m 50 50 z" because it considers it redundant. This then causes the Skia SkPath::isEmpty call to fail because Skia considers a path "m 50 50" to be empty.

This makes it impossible to correctly implement SVG zero-length linecaps for such paths.
Comment 8 Stephen Chenney 2012-01-10 14:00:41 PST
This will be fixed with 71820, I hope.
Comment 9 Stephen Chenney 2012-01-25 19:47:58 PST
Changes r105878 and r105921 fix the issue.