Selecting multiple elements in a multi select list isn't working.
Created attachment 101112 [details] Enable multiple items selection in a multi select list
Comment on attachment 101112 [details] Enable multiple items selection in a multi select list View in context: https://bugs.webkit.org/attachment.cgi?id=101112&action=review > Source/WebKit2/Shared/gtk/WebEventFactory.cpp:54 > + bool isStatePresent = gdk_event_get_state(event, &state); > + if (!isStatePresent) Might as well compress this into one line: if (!gdk_event_get_state(event, &state)) or is there a reason why that isn't a good idea?
*** This bug has been marked as a duplicate of bug 63081 ***
The bug here is that the modifier key information like ctrl/alt is not being sent during mouse clicks. Hence, when ctrl-click is done to select multiple items, it fails. This is not a dup of 63081. I will address your comment and upload a new patch. I wanted to capture why gdk_event_get_state may return false and hence I kept a variable indicating it. I will instead put it as a comment.
Created attachment 101125 [details] Enable multiple items selection in a multi select list
Created attachment 101126 [details] Enable multiple items selection in a multi select list
(In reply to comment #4) > The bug here is that the modifier key information like ctrl/alt is not being sent during mouse clicks. Hence, when ctrl-click is done to select multiple items, it fails. This is not a dup of 63081. > I will address your comment and upload a new patch. I wanted to capture why gdk_event_get_state may return false and hence I kept a variable indicating it. I will instead put it as a comment. Please accept my apologies. I meant to mark 64667 as a duplicate, not this bug!
Comment on attachment 101126 [details] Enable multiple items selection in a multi select list Clearing flags on attachment: 101126 Committed r91173: <http://trac.webkit.org/changeset/91173>
All reviewed patches have been landed. Closing bug.