Bug 64653 - DFG speculative JIT has dead code for slow calls for branches
Summary: DFG speculative JIT has dead code for slow calls for branches
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-16 13:17 PDT by Filip Pizlo
Modified: 2011-07-16 16:14 PDT (History)
3 users (show)

See Also:


Attachments
the patch (3.09 KB, patch)
2011-07-16 13:19 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2011-07-16 13:17:04 PDT
http://trac.webkit.org/changeset/91099 changed how DFG handles branches, but neglected to remove dead code for the old way that branches were handled by the DFG speculative JIT.  Specifically, the SpeculativeJIT::compilePeepHoleCall method is no longer called from anywhere, and is unlikely to ever be needed again since JITCodeGenerator now contains a more optimized version of that method.
Comment 1 Filip Pizlo 2011-07-16 13:19:36 PDT
Created attachment 101097 [details]
the patch
Comment 2 WebKit Review Bot 2011-07-16 16:14:22 PDT
Comment on attachment 101097 [details]
the patch

Clearing flags on attachment: 101097

Committed r91156: <http://trac.webkit.org/changeset/91156>
Comment 3 WebKit Review Bot 2011-07-16 16:14:26 PDT
All reviewed patches have been landed.  Closing bug.