Bug 64644 - Implement WaveShaperNode for Web Audio API
Summary: Implement WaveShaperNode for Web Audio API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-15 18:02 PDT by Chris Rogers
Modified: 2011-07-19 12:58 PDT (History)
1 user (show)

See Also:


Attachments
Patch (36.05 KB, patch)
2011-07-18 15:42 PDT, Chris Rogers
no flags Details | Formatted Diff | Diff
Patch (34.47 KB, patch)
2011-07-19 11:36 PDT, Chris Rogers
kbr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2011-07-15 18:02:52 PDT
Implement WaveShaperNode for Web Audio API
Comment 1 Chris Rogers 2011-07-18 15:42:55 PDT
Created attachment 101226 [details]
Patch
Comment 2 Chris Rogers 2011-07-18 15:45:05 PDT
The JSC bindings need a custom setter (similar to AudioBufferSourceNode .buffer attribute) since the "exec" argument is unused (generating compile warning/error).
Comment 3 Kenneth Russell 2011-07-18 18:36:58 PDT
Comment on attachment 101226 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101226&action=review

The patch generally looks good but there are a couple of seemingly unrelated changes that should be split into a separate bug.

> Source/WebCore/bindings/js/JSAudioContextCustom.cpp:96
> -            return jsUndefined();
> +            return throwVMError(exec, createSyntaxError(exec, "Error creating OfflineAudioContext"));

This change looks unrelated to this patch.

> Source/WebCore/bindings/js/JSAudioContextCustom.cpp:147
> -        return throwVMError(exec, createSyntaxError(exec, "Invalid number of channels"));
> +        return throwError(exec, createSyntaxError(exec, "Invalid number of channels"));
>  
>      if (numberOfFrames <= 0)
> -        return throwVMError(exec, createSyntaxError(exec, "Invalid number of frames"));
> +        return throwError(exec, createSyntaxError(exec, "Invalid number of frames"));
>  
>      if (sampleRate <= 0)
> -        return throwVMError(exec, createSyntaxError(exec, "Invalid sample rate"));
> +        return throwError(exec, createSyntaxError(exec, "Invalid sample rate"));

These as well.
Comment 4 Chris Rogers 2011-07-19 11:36:23 PDT
Created attachment 101350 [details]
Patch
Comment 5 Chris Rogers 2011-07-19 11:37:51 PDT
New patch removes unrelated build-fix changes to JSAudioContextCustom.cpp

I'll land that as a separate unreviewed build-fix
Comment 6 Kenneth Russell 2011-07-19 11:42:09 PDT
Comment on attachment 101350 [details]
Patch

Looks good to me.
Comment 7 Chris Rogers 2011-07-19 12:58:33 PDT
Committed r91281: <http://trac.webkit.org/changeset/91281>