Bug 64643 - Have GraphicsLayer pull their contentsScale, rather than pushing it onto them
Summary: Have GraphicsLayer pull their contentsScale, rather than pushing it onto them
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-15 17:40 PDT by Simon Fraser (smfr)
Modified: 2011-07-15 18:33 PDT (History)
3 users (show)

See Also:

Attachments
Patch (30.90 KB, patch)
2011-07-15 17:54 PDT, Simon Fraser (smfr) 		darin: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2011-07-15 17:40:38 PDT 
Have GraphicsLayer pull their contentsScale, rather than pushing it onto them
Comment 1 Simon Fraser (smfr) 2011-07-15 17:54:46 PDT 
Created attachment 101078 [details]
Patch
Comment 2 Darin Adler 2011-07-15 18:05:10 PDT 
Comment on attachment 101078 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101078&action=review

> Source/WebCore/platform/graphics/GraphicsLayer.h:354
> +    void notePageScaleFactorChangedIncludingDescendants();

Not sure I like the use of “note” here as a verb. No better name to suggest, though.
Comment 3 WebKit Review Bot 2011-07-15 18:09:05 PDT 
Comment on attachment 101078 [details]
Patch

Attachment 101078 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9094579
Comment 4 Simon Fraser (smfr) 2011-07-15 18:30:41 PDT 
http://trac.webkit.org/changeset/91137
Comment 5 Simon Fraser (smfr) 2011-07-15 18:33:36 PDT 
Windows fix in http://trac.webkit.org/changeset/91138