WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
64643
Have GraphicsLayer pull their contentsScale, rather than pushing it onto them
https://bugs.webkit.org/show_bug.cgi?id=64643
Summary
Have GraphicsLayer pull their contentsScale, rather than pushing it onto them
Simon Fraser (smfr)
Reported
2011-07-15 17:40:38 PDT
Have GraphicsLayer pull their contentsScale, rather than pushing it onto them
Attachments
Patch
(30.90 KB, patch)
2011-07-15 17:54 PDT
,
Simon Fraser (smfr)
darin
: review+
webkit.review.bot
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2011-07-15 17:54:46 PDT
Created
attachment 101078
[details]
Patch
Darin Adler
Comment 2
2011-07-15 18:05:10 PDT
Comment on
attachment 101078
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=101078&action=review
> Source/WebCore/platform/graphics/GraphicsLayer.h:354 > + void notePageScaleFactorChangedIncludingDescendants();
Not sure I like the use of “note” here as a verb. No better name to suggest, though.
WebKit Review Bot
Comment 3
2011-07-15 18:09:05 PDT
Comment on
attachment 101078
[details]
Patch
Attachment 101078
[details]
did not pass chromium-ews (chromium-xvfb): Output:
http://queues.webkit.org/results/9094579
Simon Fraser (smfr)
Comment 4
2011-07-15 18:30:41 PDT
http://trac.webkit.org/changeset/91137
Simon Fraser (smfr)
Comment 5
2011-07-15 18:33:36 PDT
Windows fix in
http://trac.webkit.org/changeset/91138
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug