Bug 64637 - DFG JIT operationCompareEqual does not inline JSValue::equalSlowCaseInline
Summary: DFG JIT operationCompareEqual does not inline JSValue::equalSlowCaseInline
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2011-07-15 15:37 PDT by Filip Pizlo
Modified: 2011-07-17 02:02 PDT (History)
3 users (show)

See Also:

the patch (1.32 KB, patch)
2011-07-15 15:39 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2011-07-15 15:37:14 PDT
The DFG JIT's slow-case implementation of operationCompareEqual makes an inline call to JSValue::equal, which checks if the operands are integers, and if not, makes a slow call to JSValue::equalSlowCase.  But operationCompareEqual will only be called if the operands are known to not be integers.  Thus, operationCompareEqual should inline the slow-case implementation.
Comment 1 Filip Pizlo 2011-07-15 15:39:25 PDT
Created attachment 101056 [details]
the patch
Comment 2 WebKit Review Bot 2011-07-17 02:02:39 PDT
Comment on attachment 101056 [details]
the patch

Clearing flags on attachment: 101056

Committed r91168: <http://trac.webkit.org/changeset/91168>
Comment 3 WebKit Review Bot 2011-07-17 02:02:43 PDT
All reviewed patches have been landed.  Closing bug.