Bug 64635 - Refactor TestExpectationModel to use TestExpectationLine as data item.
Summary: Refactor TestExpectationModel to use TestExpectationLine as data item.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks: 64385
  Show dependency treegraph
 
Reported: 2011-07-15 15:26 PDT by Dimitri Glazkov (Google)
Modified: 2011-07-15 15:49 PDT (History)
2 users (show)

See Also:


Attachments
Patch (11.67 KB, patch)
2011-07-15 15:35 PDT, Dimitri Glazkov (Google)
no flags Details | Formatted Diff | Diff
Patch (12.31 KB, patch)
2011-07-15 15:43 PDT, Dimitri Glazkov (Google)
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-07-15 15:26:30 PDT
Refactor TestExpectationModel to use TestExpectationLine as data item.
Comment 1 Dimitri Glazkov (Google) 2011-07-15 15:35:46 PDT
Created attachment 101055 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2011-07-15 15:41:19 PDT
Comment on attachment 101055 [details]
Patch

got an even better one.
Comment 3 Dimitri Glazkov (Google) 2011-07-15 15:43:14 PDT
Created attachment 101057 [details]
Patch
Comment 4 Adam Barth 2011-07-15 15:46:19 PDT
Comment on attachment 101057 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101057&action=review

> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:655
> -        self._model = TestExpectationsModel(port)
> +        self._model = TestExpectationsModel()

Yay!
Comment 5 Dimitri Glazkov (Google) 2011-07-15 15:49:33 PDT
Committed r91124: <http://trac.webkit.org/changeset/91124>