Bug 64626 – An arrow key collapses directionless selection range in the wrong direction in BiDi

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Ryosuke Niwa]

When a selection range is collapsed by an arrow key, the the caret appears on the wrong direction if the text's direction is different from that of block.

e.g. if we had RTL text CBA in a LTR block, and B was selected, pressing left-arrow key collapses the selection on the right of B.

[Xiaomei Ji]

currently, when pressing left arrow, webkit collapses the selection to the logical beginning in LTR context, and collapse the selection to the logical end in RTL context.

Amnon, Jeremy, and Aharon all agree that: collapsing the selection in the visual direction is what is expected to happen.

[Ryosuke Niwa]

Created attachment 101075 [details]
fixes the bug

[WebKit Review Bot]

Comment on attachment 101075 [details]
fixes the bug

Attachment 101075 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9092544

New failing tests:
editing/selection/collapse-selection-in-bidi.html

[Ryosuke Niwa]

Ping reviewers

[Ryosuke Niwa]

Ping reviewers.

[Darin Adler]

Comment on attachment 101075 [details]
fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=101075&action=review

Seems fine.

> Source/WebCore/editing/FrameSelection.cpp:379
> +    int offset = 0;

Seems non-helpful to initialize this to 0.

[Ryosuke Niwa]

Committed r93221: <http://trac.webkit.org/changeset/93221>