Bug 64625 - Add isSpeechInputEnabled flag to WebContextMenuData
Summary: Add isSpeechInputEnabled flag to WebContextMenuData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 39485
  Show dependency treegraph
 
Reported: 2011-07-15 13:55 PDT by gshires
Modified: 2011-07-20 10:02 PDT (History)
4 users (show)

See Also:


Attachments
Proposed patch (1.75 KB, patch)
2011-07-15 13:55 PDT, gshires
fishd: review+
Details | Formatted Diff | Diff
Proposed patch (2.53 KB, patch)
2011-07-19 12:49 PDT, gshires
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description gshires 2011-07-15 13:55:01 PDT
Created attachment 101040 [details]
Proposed patch

This flag is to be used by a new menu item "Voice recognition options" which will be added to Chromium. This patch is necessary so that the menu item only appears for input-fields containing the x-webkit-speech attribute.

The chromium code that will make use of this patch and that implements the context menu item "Voice recognition options" is: http://codereview.chromium.org/7086005
Comment 1 Satish Sampath 2011-07-19 00:46:21 PDT
+Darin to approve the addition to WebKit/chromium/public API

All patches should have an entry to the appropriate ChangeLog file. For this patch, please add an entry to WebKit/ChangeLog. You can do this with the 'Tools/Scripts/prepare-ChangeLog' script. For more info see http://www.webkit.org/coding/contributing.html#changelogs

ContextMenuClientImpl.cpp:264 - should indent by 4 spaces, not 2.
Comment 2 gshires 2011-07-19 12:49:11 PDT
Created attachment 101363 [details]
Proposed patch

Fixed spacing and added ChangeLog entry.
Comment 3 Tony Gentilcore 2011-07-20 08:29:15 PDT
Comment on attachment 101363 [details]
Proposed patch

For future reference, when you want a reviewer to add a patch to the commit queue for you just set the cq field to "?". Some committers like to commit manually and it is hard to remember who has committer rights, so typically reviewers will not cq+ unless it is requested.
Comment 4 WebKit Review Bot 2011-07-20 10:02:02 PDT
Comment on attachment 101363 [details]
Proposed patch

Clearing flags on attachment: 101363

Committed r91377: <http://trac.webkit.org/changeset/91377>
Comment 5 WebKit Review Bot 2011-07-20 10:02:06 PDT
All reviewed patches have been landed.  Closing bug.