Bug 64625 – Add isSpeechInputEnabled flag to WebContextMenuData

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

Created attachment 101040 [details]
Proposed patch

This flag is to be used by a new menu item "Voice recognition options" which will be added to Chromium. This patch is necessary so that the menu item only appears for input-fields containing the x-webkit-speech attribute.

The chromium code that will make use of this patch and that implements the context menu item "Voice recognition options" is: http://codereview.chromium.org/7086005

[Satish Sampath]

+Darin to approve the addition to WebKit/chromium/public API

All patches should have an entry to the appropriate ChangeLog file. For this patch, please add an entry to WebKit/ChangeLog. You can do this with the 'Tools/Scripts/prepare-ChangeLog' script. For more info see http://www.webkit.org/coding/contributing.html#changelogs

ContextMenuClientImpl.cpp:264 - should indent by 4 spaces, not 2.

Created attachment 101363 [details]
Proposed patch

Fixed spacing and added ChangeLog entry.

[Tony Gentilcore]

Comment on attachment 101363 [details]
Proposed patch

For future reference, when you want a reviewer to add a patch to the commit queue for you just set the cq field to "?". Some committers like to commit manually and it is hard to remember who has committer rights, so typically reviewers will not cq+ unless it is requested.

[WebKit Review Bot]

Comment on attachment 101363 [details]
Proposed patch

Clearing flags on attachment: 101363

Committed r91377: <http://trac.webkit.org/changeset/91377>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.