Bug 64599 - Web Inspector: Web Inspector: provide unique identifiers for loaders
Summary: Web Inspector: Web Inspector: provide unique identifiers for loaders
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-15 07:53 PDT by Vsevolod Vlasov
Modified: 2011-07-18 07:04 PDT (History)
11 users (show)

See Also:


Attachments
Patch (7.67 KB, patch)
2011-07-15 07:57 PDT, Vsevolod Vlasov
no flags Details | Formatted Diff | Diff
Patch (7.71 KB, patch)
2011-07-15 11:17 PDT, Vsevolod Vlasov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2011-07-15 07:53:53 PDT
Currently, we use loader address as a loader id, this does not guarantee loader ids to be unique through the life time of the process.
We now use the same technique used to create unique frame ids for loaders.
Comment 1 Vsevolod Vlasov 2011-07-15 07:57:53 PDT
Created attachment 100979 [details]
Patch
Comment 2 Vsevolod Vlasov 2011-07-15 11:17:37 PDT
Created attachment 101010 [details]
Patch
Comment 3 Pavel Feldman 2011-07-18 05:43:21 PDT
Comment on attachment 101010 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101010&action=review

> Source/WebCore/inspector/InspectorPageAgent.h:135
> +    HashMap<DocumentLoader*, String> m_loaderToIdentifier;

Could you make this field static?
Comment 4 WebKit Review Bot 2011-07-18 07:04:43 PDT
Comment on attachment 101010 [details]
Patch

Clearing flags on attachment: 101010

Committed r91184: <http://trac.webkit.org/changeset/91184>
Comment 5 WebKit Review Bot 2011-07-18 07:04:47 PDT
All reviewed patches have been landed.  Closing bug.