Bug 64598 - TestFailures page's TestFailureBugForm class has a bad name
Summary: TestFailures page's TestFailureBugForm class has a bad name
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-15 07:28 PDT by Adam Roben (:aroben)
Modified: 2011-07-15 08:10 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.66 KB, patch)
2011-07-15 07:29 PDT, Adam Roben (:aroben) 		no flags Details | Formatted Diff | Diff
Rename TestFailureBugForm to FailingTestsBugForm (7.67 KB, patch)
2011-07-15 07:57 PDT, Adam Roben (:aroben) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-07-15 07:28:13 PDT 
TestFailures page's TestFailureBugForm class has a bad name
Comment 1 Adam Roben (:aroben) 2011-07-15 07:29:21 PDT 
Created attachment 100974 [details]
Patch
Comment 2 Daniel Bates 2011-07-15 07:53:00 PDT 
Comment on attachment 100974 [details]
Patch

Where is the part of this patch that actually renames the class? I only see one callsite change.
Comment 3 Adam Roben (:aroben) 2011-07-15 07:55:49 PDT 
(In reply to comment #2)
> (From update of attachment 100974 [details])
> Where is the part of this patch that actually renames the class? I only see one callsite change.

I guess webkit-patch upload didn't like my changes for some reason. I'll upload a new patch.
Comment 4 Adam Roben (:aroben) 2011-07-15 07:57:47 PDT 
Created attachment 100978 [details]
Rename TestFailureBugForm to FailingTestsBugForm
Comment 5 WebKit Review Bot 2011-07-15 08:10:32 PDT 
Comment on attachment 100978 [details]
Rename TestFailureBugForm to FailingTestsBugForm

Clearing flags on attachment: 100978

Committed r91068: <http://trac.webkit.org/changeset/91068>
Comment 6 WebKit Review Bot 2011-07-15 08:10:37 PDT 
All reviewed patches have been landed.  Closing bug.