Bug 64597 - [Qt] Push the new viewport rect to the drawing area when committing the scale.
Summary: [Qt] Push the new viewport rect to the drawing area when committing the scale.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jocelyn Turcotte
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-15 06:45 PDT by Jocelyn Turcotte
Modified: 2011-07-18 06:48 PDT (History)
1 user (show)

See Also:


Attachments
Patch (5.20 KB, patch)
2011-07-15 06:50 PDT, Jocelyn Turcotte
no flags Details | Formatted Diff | Diff
Patch (1.41 KB, patch)
2011-07-15 08:15 PDT, Jocelyn Turcotte
benjamin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jocelyn Turcotte 2011-07-15 06:45:23 PDT
[Qt] Push the new viewport rect to the drawing area when committing the scale.
Comment 1 Jocelyn Turcotte 2011-07-15 06:50:30 PDT
Created attachment 100970 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2011-07-15 06:53:01 PDT
Comment on attachment 100970 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100970&action=review

> Source/WebKit2/UIProcess/API/qt/qtouchwebpage.cpp:130
>      page->setContentsScale(q->scale());
> +    viewport->d->viewportRectUpdated();

I am wondering, when we have suspend/resume working we could update this (and visibleContentRect) when resuming.
Comment 3 Benjamin Poulain 2011-07-15 06:58:01 PDT
I would prefer if the page was not calling functions on the viewport. I am always afraid of coming back to the old code where every class knew about the internal of every other classes.

It feels like TouchViewInterface might be the right place to call viewportRectUpdated()?
Comment 4 Jocelyn Turcotte 2011-07-15 08:15:10 PDT
Created attachment 100984 [details]
Patch

Simpler patch after removing the scale commit timer (see bug 64600).
Comment 5 Benjamin Poulain 2011-07-15 08:23:08 PDT
Comment on attachment 100984 [details]
Patch

Nice.
Comment 6 Jocelyn Turcotte 2011-07-18 06:48:31 PDT
Committed r91182: <http://trac.webkit.org/changeset/91182>