Bug 64589 – Upstream QtWebKit/N9 changes related to visibleContentRect

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Kenneth Rohde Christiansen]

SSIA

[Kenneth Rohde Christiansen]

Created attachment 100949 [details]
Patch

[WebKit Review Bot]

Attachment 100949 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebKit2/UIProcess/WebPageProxy.h:340:  The parameter name "rect" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Hausmann]

Comment on attachment 100949 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100949&action=review

r=me but fix the style issue before landing I'd say.

> Source/WebCore/platform/ScrollView.cpp:240
> -                   IntSize(max(0, m_boundsSize.width() - verticalScrollbarWidth), 
> +                   IntSize(max(0, m_boundsSize.width() - verticalScrollbarWidth),

You could skip this part when landing :)

[Kenneth Rohde Christiansen]

Created attachment 100954 [details]
Patch for landing

[Kenneth Rohde Christiansen]

Created attachment 100955 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 100955 [details]
Patch for landing

Clearing flags on attachment: 100955

Committed r91064: <http://trac.webkit.org/changeset/91064>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Zoltan Herczeg]

This patch killed the Qt buildbot (early exit after 500 fail): http://build.webkit.org/builders/Qt%20Linux%20Release/builds/35397/steps/layout-test/logs/stdio

any idea?

[Kenneth Rohde Christiansen]

(In reply to comment #8)
> This patch killed the Qt buildbot (early exit after 500 fail): http://build.webkit.org/builders/Qt%20Linux%20Release/builds/35397/steps/layout-test/logs/stdio
> 
> any idea?

Strange. We are not running the bots using tiling and fixed layout, so this shouldnt be affected.

[Kenneth Rohde Christiansen]

I think I found the issue.

void FrameLoaderClientQt::transitionToCommittedForNewPage() doesn't check if it is in resize to contents mode.

Patch in the making

[Kenneth Rohde Christiansen]

Created attachment 100995 [details]
Regression fix

[WebKit Review Bot]

Attachment 100995 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/ChangeLog', u'Source/WebK..." exit_code: 1

Source/WebKit/qt/ChangeLog:3:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 100995 [details]
Regression fix

Clearing flags on attachment: 100995

Committed r91079: <http://trac.webkit.org/changeset/91079>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.