Bug 64588 - gardening server should proxy buildbot status for garden-o-matic
Summary: gardening server should proxy buildbot status for garden-o-matic
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 64190
  Show dependency treegraph
 
Reported: 2011-07-15 01:48 PDT by Adam Barth
Modified: 2011-07-15 21:03 PDT (History)
3 users (show)

See Also:


Attachments
Patch (7.63 KB, patch)
2011-07-15 01:50 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-07-15 01:48:50 PDT
gardening server should proxy buildbot status for garden-o-matic
Comment 1 Adam Barth 2011-07-15 01:50:28 PDT
Created attachment 100948 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-07-15 01:52:45 PDT
Comment on attachment 100948 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100948&action=review

OK.

> Tools/Scripts/webkitpy/tool/mocktool.py:841
> +        self._chromium_buildbot = MockBuildBot()

MIght want to give it a differnet url.

> Tools/Scripts/webkitpy/tool/mocktool.py:859
> +    def chromium_buildbot(self):
> +        return self._chromium_buildbot

we should figure out if we should move to @property-style getters one of these days.
Comment 3 Adam Barth 2011-07-15 02:00:07 PDT
(In reply to comment #2)
> (From update of attachment 100948 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=100948&action=review
> 
> > Tools/Scripts/webkitpy/tool/mocktool.py:841
> > +        self._chromium_buildbot = MockBuildBot()
> 
> MIght want to give it a differnet url.

Yeah, I thought about that, but then I decided it didn't really matter.  We can do that once we have our first bot about using the wrong one.

> > Tools/Scripts/webkitpy/tool/mocktool.py:859
> > +    def chromium_buildbot(self):
> > +        return self._chromium_buildbot
> 
> we should figure out if we should move to @property-style getters one of these days.

I agree that it's super annoying that some of these require function calls and some don't need the ().  It won't actually be that hard to fix globally.  We could rename tool to host at the same time.
Comment 4 WebKit Review Bot 2011-07-15 21:03:32 PDT
Comment on attachment 100948 [details]
Patch

Clearing flags on attachment: 100948

Committed r91144: <http://trac.webkit.org/changeset/91144>
Comment 5 WebKit Review Bot 2011-07-15 21:03:37 PDT
All reviewed patches have been landed.  Closing bug.