Bug 64576 - Add regression tests for legacy color parsing of valid CSS colors
: Add regression tests for legacy color parsing of valid CSS colors
Product: WebKit
Classification: Unclassified
Component: HTML DOM
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Tab Atkins
Depends on:
  Show dependency treegraph
Reported: 2011-07-14 17:35 PDT by Tab Atkins
Modified: 2011-07-18 15:49 PDT (History)
3 users (show)

See Also:

Patch (3.23 KB, patch)
2011-07-18 14:50 PDT, Tab Atkins
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tab Atkins 2011-07-14 17:35:46 PDT
Using a valid CSS color other than a named color or a 3/6 digit hex color should use the legacy parsing code, rather than accepting the value and treating it like a valid CSS color.  There aren't currently enough regression tests surrounding this.

Specifically, we seem to need tests for "currentColor", the rgba() function, and the hsl() and hsla() functions.
Comment 1 Tab Atkins 2011-07-18 14:50:23 PDT
Created attachment 101206 [details]
Comment 2 Tab Atkins 2011-07-18 14:51:50 PDT
Newly added people, can I get a quick r+?  This is just a four-line addition to the tests, plus updated expectations.
Comment 3 WebKit Review Bot 2011-07-18 15:49:51 PDT
Comment on attachment 101206 [details]

Clearing flags on attachment: 101206

Committed r91217: <http://trac.webkit.org/changeset/91217>
Comment 4 WebKit Review Bot 2011-07-18 15:49:56 PDT
All reviewed patches have been landed.  Closing bug.