Bug 64576 - Add regression tests for legacy color parsing of valid CSS colors
: Add regression tests for legacy color parsing of valid CSS colors
Status: RESOLVED FIXED
: WebKit
HTML DOM
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-07-14 17:35 PST by
Modified: 2011-07-18 15:49 PST (History)


Attachments
Patch (3.23 KB, patch)
2011-07-18 14:50 PST, Tab Atkins
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-07-14 17:35:46 PST
Using a valid CSS color other than a named color or a 3/6 digit hex color should use the legacy parsing code, rather than accepting the value and treating it like a valid CSS color.  There aren't currently enough regression tests surrounding this.

Specifically, we seem to need tests for "currentColor", the rgba() function, and the hsl() and hsla() functions.
------- Comment #1 From 2011-07-18 14:50:23 PST -------
Created an attachment (id=101206) [details]
Patch
------- Comment #2 From 2011-07-18 14:51:50 PST -------
Newly added people, can I get a quick r+?  This is just a four-line addition to the tests, plus updated expectations.
------- Comment #3 From 2011-07-18 15:49:51 PST -------
(From update of attachment 101206 [details])
Clearing flags on attachment: 101206

Committed r91217: <http://trac.webkit.org/changeset/91217>
------- Comment #4 From 2011-07-18 15:49:56 PST -------
All reviewed patches have been landed.  Closing bug.