Bug 64571 - ARMv7 backend broken, lacks 3 parameter rshift32 method
Summary: ARMv7 backend broken, lacks 3 parameter rshift32 method
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xan Lopez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-14 16:13 PDT by Xan Lopez
Modified: 2011-07-19 11:34 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.50 KB, patch)
2011-07-14 16:15 PDT, Xan Lopez 		no flags Details | Formatted Diff | Diff
Patch (15.68 KB, patch)
2011-07-14 16:17 PDT, Xan Lopez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xan Lopez 2011-07-14 16:13:14 PDT 
Summary says it all.
Comment 1 Xan Lopez 2011-07-14 16:15:59 PDT 
Created attachment 100885 [details]
Patch
Comment 2 Xan Lopez 2011-07-14 16:17:51 PDT 
Created attachment 100887 [details]
Patch
Comment 3 Zoltan Herczeg 2011-07-18 23:19:10 PDT 
Comment on attachment 100885 [details]
Patch

LGTM.

On x86-32, all three shifts have 3 operand opcode, might be a good idea to add them later. But this patch is basically a build-fix, and should be landed.
Comment 4 Xan Lopez 2011-07-19 11:34:01 PDT 
Comment on attachment 100885 [details]
Patch

Clearing flags on attachment: 100885

Committed r91275: <http://trac.webkit.org/changeset/91275>
Comment 5 Xan Lopez 2011-07-19 11:34:08 PDT 
All reviewed patches have been landed.  Closing bug.