Bug 64569 - Support "Jump to Selection" in WebKit2 on Mac
Summary: Support "Jump to Selection" in WebKit2 on Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ada Chan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-07-14 16:03 PDT by Ada Chan
Modified: 2011-09-14 09:52 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.99 KB, patch)
2011-07-14 16:36 PDT, Ada Chan 		no flags Details | Formatted Diff | Diff
Patch (2nd version) (5.19 KB, patch)
2011-07-15 13:18 PDT, Ada Chan 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ada Chan 2011-07-14 16:03:25 PDT 
To do this, we need to implement the CenterSelectionInVisibleArea editor command in WebCore.

<rdar://problem/9732174>
Comment 1 Ada Chan 2011-07-14 16:36:12 PDT 
Created attachment 100893 [details]
Patch
Comment 2 Ada Chan 2011-07-15 13:17:15 PDT 
I forgot that besides scrolling the selection into view, I also need to flash the find indicator (bounce the yellow bubble around the selection) when that command is triggered.  I'm going to send a new patch, and since the find indicator is not part of WebCore, I might as well just handle everything within WebKit.
Comment 3 Ada Chan 2011-07-15 13:18:11 PDT 
Created attachment 101032 [details]
Patch (2nd version)
Comment 4 Ada Chan 2011-09-14 09:52:17 PDT 
Committed: http://trac.webkit.org/changeset/91108