Bug 64568 - REGRESSION: webkit-patch roll-chromium-deps is broken
Summary: REGRESSION: webkit-patch roll-chromium-deps is broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-14 16:01 PDT by Ryosuke Niwa
Modified: 2011-07-14 16:23 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.29 KB, patch)
2011-07-14 16:08 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Patch (2.12 KB, patch)
2011-07-14 16:20 PDT, Ryosuke Niwa 		dpranke: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-07-14 16:01:04 PDT 
webkit-patch roll-chromium-deps blows up with the following error:

rniwa-macpro:webkit2 rniwa$ Tools/Scripts/webkit-patch roll-chromium-deps 92606
Traceback (most recent call last):
  File "Tools/Scripts/webkit-patch", line 66, in <module>
    main()
  File "Tools/Scripts/webkit-patch", line 61, in main
    WebKitPatch(__file__).main()
  File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 308, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 117, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 51, in execute
    self._sequence.run_and_handle_errors(tool, options, state)
  File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run
    step(tool, options).run(state)
  File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/steps/updatechromiumdeps.py", line 69, in run
    deps = self._tool.checkout().chromium_deps()
  File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 151, in chromium_deps
    return DEPS(self._scm.absolute_path("Source", "WebKit", "chromium", "DEPS"))
TypeError: absolute_path() takes exactly 2 arguments (5 given)
Comment 1 Ryosuke Niwa 2011-07-14 16:08:26 PDT 
Created attachment 100884 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-07-14 16:12:15 PDT 
Comment on attachment 100884 [details]
Patch

LGTM too.  Sorry for the trouble.  We really should test this method....
Comment 3 Ryosuke Niwa 2011-07-14 16:20:08 PDT 
Created attachment 100889 [details]
Patch
Comment 4 Ryosuke Niwa 2011-07-14 16:23:15 PDT 
Committed r91033: <http://trac.webkit.org/changeset/91033>