Bug 64560 - [Qt] Compiling error in Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp with Qt 4.7 or older
Summary: [Qt] Compiling error in Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P3 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2011-07-14 14:07 PDT by Hui Huang
Modified: 2011-07-18 10:13 PDT (History)
3 users (show)

See Also:


Attachments
Proposed patch (1.35 KB, patch)
2011-07-15 07:56 PDT, Hui Huang
noam: review-
noam: commit-queue-
Details | Formatted Diff | Diff
Patch with changes based on review (1.36 KB, patch)
2011-07-18 08:15 PDT, Hui Huang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hui Huang 2011-07-14 14:07:30 PDT
The following line in the function tst_QWebElement::render() doesn't compile on Qt 4.7 or older versions:
tables[0].render(&painter, chunkPaintRect);

The method void QWebElement::render(QPainter * painter, const QRect & clip) is introduced in Qt 4.8 (http://doc.qt.nokia.com/4.8-snapshot/qwebelement.html#render). It is not available in Qt 4.7 or older (http://doc.qt.nokia.com/4.7/qwebelement.html#render).
Comment 1 Hui Huang 2011-07-15 07:56:02 PDT
Created attachment 100977 [details]
Proposed patch
Comment 2 Noam Rosenthal 2011-07-16 15:00:22 PDT
Comment on attachment 100977 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100977&action=review

> Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp:1026
> +#if QT_VERSION >= 0x040800

Please use QT_VERSION_CHECK(4, 8, 0) instead of 0x040800
Comment 3 Hui Huang 2011-07-18 07:20:02 PDT
Thanks for reviewing the patch. I just made the change and it compiled without any problem. I will submit the new patch.

(In reply to comment #2)
> (From update of attachment 100977 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=100977&action=review
> 
> > Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp:1026
> > +#if QT_VERSION >= 0x040800
> 
> Please use QT_VERSION_CHECK(4, 8, 0) instead of 0x040800
Comment 4 Hui Huang 2011-07-18 08:15:13 PDT
Created attachment 101159 [details]
Patch with changes based on review
Comment 5 WebKit Review Bot 2011-07-18 10:13:00 PDT
Comment on attachment 101159 [details]
Patch with changes based on review

Clearing flags on attachment: 101159

Committed r91193: <http://trac.webkit.org/changeset/91193>
Comment 6 WebKit Review Bot 2011-07-18 10:13:04 PDT
All reviewed patches have been landed.  Closing bug.