The following line in the function tst_QWebElement::render() doesn't compile on Qt 4.7 or older versions: tables[0].render(&painter, chunkPaintRect); The method void QWebElement::render(QPainter * painter, const QRect & clip) is introduced in Qt 4.8 (http://doc.qt.nokia.com/4.8-snapshot/qwebelement.html#render). It is not available in Qt 4.7 or older (http://doc.qt.nokia.com/4.7/qwebelement.html#render).
Created attachment 100977 [details] Proposed patch
Comment on attachment 100977 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=100977&action=review > Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp:1026 > +#if QT_VERSION >= 0x040800 Please use QT_VERSION_CHECK(4, 8, 0) instead of 0x040800
Thanks for reviewing the patch. I just made the change and it compiled without any problem. I will submit the new patch. (In reply to comment #2) > (From update of attachment 100977 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=100977&action=review > > > Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp:1026 > > +#if QT_VERSION >= 0x040800 > > Please use QT_VERSION_CHECK(4, 8, 0) instead of 0x040800
Created attachment 101159 [details] Patch with changes based on review
Comment on attachment 101159 [details] Patch with changes based on review Clearing flags on attachment: 101159 Committed r91193: <http://trac.webkit.org/changeset/91193>
All reviewed patches have been landed. Closing bug.